Skip to content

Patching memory leak using tracer #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

aryanjassal
Copy link
Member

@aryanjassal aryanjassal commented May 21, 2025

Description

This PR will integrate the experimental tracer from js-logger to trace the memory leak to finally patch it. This should make the polykey seednodes stable and robust. This will also act as a live-fire exercise for the tracer.

Issues Fixed

Tasks

  • 1. Integrate tracer into js code
  • 2. Integrate tracer into native code
  • 3. Replicate memory leak with test/script
  • 4. Use tracer to visualise where the leak is coming from

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@aryanjassal aryanjassal self-assigned this May 21, 2025
Copy link

linear bot commented May 21, 2025

ENG-626

@aryanjassal
Copy link
Member Author

A quick test against object lifecycles and tracer has confirmed that no object is being leaked, although the parent/child relationship is still kind of messed up. I'm working on fixing that right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Integrate tracer to detect memory leaks
1 participant