-
Notifications
You must be signed in to change notification settings - Fork 57
Add validation of custom grok patterns file #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Marusyk please elaborate so that i can get started |
@ManasviGoyal thanks for your interest. You can start whenever you want |
@ManasviGoyal this is about bug IndexOutOfRangeException and about adding some validation |
Hi @ManasviGoyal, are you still working on that? |
I am busy with some work this month. You can can assign it someone else. No issue with me. |
Hi, i would like to try to fix it. Can i? |
Hello, I would like to contribute to this issue as well |
* #18 custom pattern validation * Unit test for wrong custom pattern * Check if custom pattern is correct * moved pattern validation inside ProcessPatternLine * throw FormatException on wrong custom pattern load * Check if pattern is valid * Added const value for LoadWrongCustomPatterns * removed unnecessary `String.Format` Co-authored-by: Giovanni Maria Zanchetta <[email protected]>
Context
The support of custom grok patterns was added in #15
Just add the directory with name
Patterns
and a file (the file name doesn't matter) with your own patterns.Like Patterns\grok-custom-patterns:
and use:
IndexOutOfRangeException
There is an issue when that custom file has the wrong content.
How to reproduce
Add to the Patterns\grok-custom-patterns the following data:
How to fix
Add some validation on load of custom grok file content. It should be pattern name, space, then the regexp for that pattern
The text was updated successfully, but these errors were encountered: