Skip to content

[2.0.x] Add delta_height variable in lieu of using home_offset #8344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

tcm0116
Copy link
Contributor

@tcm0116 tcm0116 commented Nov 9, 2017

#8229 appears to have broken the height adjustment for Delta machines due to the way that the height was adjusted via home_offset[Z_AXIS]. This PR adds a dedicated delta_height variable that can be directly adjusted and also ensures that the current_position and soft_endstop limits are configured appropriately after homing.

I tested this on my Delta machine with the default DELTA_HEIGHT set to values +- 20mm from the true height of my machine.


With DELTA_HEIGHT set to 20mm less than the true height, G33 generates probing failed messages after the first probe event because the first probe attempts to go to -50, but the subsequent probes only go to -10, so they never reach the bed. Running G33 P1 to just set the delta height prior to running G33 allows the calibration to succeed.

With DELTA_HEIGHT set to 20mm greater than the true height, G33 succeeds, but the first iteration ends up double probing each probe event because the probe is triggered during the fast movement phase of the probe.

I think we should look into making G33 first perform a single probe followed by a home to set the delta height (i.e. G33 P1), and then continue with the iterations. Perhaps @LVD-AC can help with this since G33 is rather complicated. In any case, this is the same behavior as prior to #8229, so I think we can continue with this PR and apply any updates to G33 is a separate PR.

@LVD-AC
Copy link
Contributor

LVD-AC commented Nov 9, 2017

@tcm0116
The same applies to the delta radius, if you set it off by +/-20mm the probing is done in mid air or it scrapes the bed. And making this idiot proof is not as easy as for the delta height.

G33 can cope with differences of several mm and trims them right to a couple of microns. But honestly if someone is not capable to use a ruler and measure the basic dimensions of the printer with a precision of a couple mm, they should not be building delta printers.

Increase Z_CLEARANCE_BETWEEN_PROBES if the probe triggers during the fast move.

@tcm0116 tcm0116 deleted the 2.0.x-delta_height branch December 31, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants