UBL map bug fix #7265
Merged
UBL map bug fix #7265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2017
|
I'm not sure we want to add 'Yet Another Travis Test' but it might be good to piggy back on a different configuration if possible. It would be good to have some (limited is OK!) test coverage for UBL being turned on but the LCD Panel is not turned on. Right now, we don't have any test coverage for this scenario. And that is why this Pull Request is being merged... This case snuck through the gauntlet. |
nomukaiki
pushed a commit
to nomukaiki/Marlin
that referenced
this pull request
Jul 9, 2017
* bugfix-1.1.x: (511 commits) Bugfix (MarlinFirmware#7265) Corrections (MarlinFirmware#7231) Arrange example configurations by vendor Add some config names to AUTHOR Add support for BQ heated bed kit with Hephestos 2 Support for Creality CR-10 Assign -1 to LCD_PINS_D4-7 if not defined Tweaks for M43 Fix: Use of digitalRead, digitalWrite breaks on AT90USB Clean up excess whitespace Add `BUSY_WHILE_HEATING` for hosts that need it Clear SHOW_BOOTSCREEN with no LCD Fix compile issue with G38 Patch M23 to work around Simplify3D bug Add PROBE_MANUALLY support to G33 Fix a bug in mfup UTF-8 mapper for Czech DISABLE_[XYZ] compatibility check Add kill action Add "CAP:PRINT_JOB:1" (M75 / M76 / M77) to M115 output ... # Conflicts: # Marlin/Configuration.h # Marlin/Configuration_adv.h
|
@Roxy-3D - maybe add a "Travis Candidate" tag for possible later review, or is it too obvious ? |
|
Done! (That was a good idea! We need a way to flag those types of things.) |
orobardet
pushed a commit
to orobardet/Renren3DPro-Marlin
that referenced
this pull request
Aug 21, 2017
Fix compile error when UBL is enabled but there is no LCD Panel.
rpls
pushed a commit
to rpls/Marlin
that referenced
this pull request
Nov 10, 2017
Fix compile error when UBL is enabled but there is no LCD Panel.
damicreabox
pushed a commit
to damicreabox/Marlin
that referenced
this pull request
Sep 14, 2018
Fix compile error when UBL is enabled but there is no LCD Panel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile error when UBL is defined, but no lcd is defined.