Fix Z_DUAL_ENDSTOPS with Z MIN Homing #4562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
thinkyhead
force-pushed
the
rc_fix_z_dual_endstops
branch
from
dd4a361 to
462e189
Compare
Closed
drewmoseley
pushed a commit
to drewmoseley/Marlin
that referenced
this pull request
May 31, 2024
…uto_home_layer_shift PFW-1551: Fix Pause->Tune->Auto Home layer shift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #4531
The conditional code for
Z_DUAL_ENDSTOPSis broken, apparently…Z_DUAL_ENDSTOPSfails to work for this case.#undefs theUSE_*_PLUGthat the endstop needs, so it's possible that the endstop pin is set to -1 retroactively (as the pre-compiler does tricky management of out-of-order inter-dependent defines).This PR corrects these conditionals in the hope that it will restore this feature to working order. Please test!