Skip to content

Improve STATIC_ITEM implementation #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 12, 2016

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Jul 8, 2016

The STATIC_ITEM macro pushes the cursor down so it can't go above the bottom item. This ensures that when you start to scroll down, the display begins to scroll right away. (Caveats to follow.) This PR makes sure that the screen is re-drawn after one of these cursor corrections.

A more complete solution needs to account for scrolling upward. When scrolling upward the cursor should not be limited, so that you can scroll the top line back into view. You'll notice that the Printer Info screen suffers from this issue, for example. So this will be followed up with more commits once this is worked out.

  • Rename START_ROW to START_COL and apply it properly (if it's got to be in there at all).
  • Rename menu macro local vars for clarity.
  • Update END_SCREEN (used for static-only screens) so it scrolls more simply, merely adjusting the top-line.
  • Screens with only a single STATIC_ITEM above MENU_ITEMs will behave as before, pushing the cursor down by one line on the first redraw.
  • Add the ability to invert headings and invert some info headings. As a test. (Bold is also possible, if better.)
  • Left-justify some info lines, leaving the build info centered.

@thinkyhead thinkyhead force-pushed the rc_fix_static_scrolling branch from b90c786 to e1feeb7 Compare July 8, 2016 22:27
@thinkyhead thinkyhead changed the title Redraw after cursor correction in STATIC_ITEM Improve STATIC_ITEM implementation Jul 9, 2016
@thinkyhead thinkyhead force-pushed the rc_fix_static_scrolling branch from 749017c to d17b161 Compare July 12, 2016 01:14
@thinkyhead thinkyhead merged commit 6e68dd2 into MarlinFirmware:RCBugFix Jul 12, 2016
@thinkyhead thinkyhead deleted the rc_fix_static_scrolling branch July 12, 2016 01:25
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
@thinkyhead thinkyhead mentioned this pull request Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants