Improve STATIC_ITEM implementation #4243
Merged
+125
−103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
STATIC_ITEM
macro pushes the cursor down so it can't go above the bottom item. This ensures that when you start to scroll down, the display begins to scroll right away. (Caveats to follow.) This PR makes sure that the screen is re-drawn after one of these cursor corrections.A more complete solution needs to account for scrolling upward. When scrolling upward the cursor should not be limited, so that you can scroll the top line back into view. You'll notice that the Printer Info screen suffers from this issue, for example. So this will be followed up with more commits once this is worked out.
START_ROW
toSTART_COL
and apply it properly (if it's got to be in there at all).END_SCREEN
(used for static-only screens) so it scrolls more simply, merely adjusting the top-line.STATIC_ITEM
aboveMENU_ITEM
s will behave as before, pushing the cursor down by one line on the first redraw.