Fix tmc2240 sensorless homing #27907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 385ddb9)
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
3791e7d to
6ea4a16
Compare
|
Currently the code is requiring active-HIGH versus active-LOW like so: It's not entirely clear why we made TMC2209 the exception and why we want to follow the same pattern with 2240. Which active state is more advantageous in your opinion? |
|
Marlin didn't do an exception, the 2209 can only do push pull (with active low) in diag0. The 2240 (and 5160 and maybe others) can do both open collector (with active low) and push pull (with active high) The advantage of configuring the 2240 as push pull is that is the same as the 2209. If some board has a pull down (or an mcu doesn't have an internal pullup) then this would potentially be safer. Bot mostly because it is the smallest change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2240 uses open collector output on diag0 by default, which is active low.
This change sets it up as push pull active high which should make sensorless homing work
Description
Requirements
Benefits
Configurations
Related Issues