Fix LIN_ADVANCE ProUI #27895
Merged
Fix LIN_ADVANCE ProUI #27895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into bugfix-2.1.x-May6
… into bugfix-2.1.x-May6
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
3791e7d to
6ea4a16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Editing the value causes the value to reset to zero when reselecting.
This is more of an annoyance rather than a strict bug. However, adding
static- changing tostatic float editable_k = planner.get_advance_k();does make this work in a way, but in my testing it doesn't update correctly in the way it matters. such as going to another menu and back.So the proposed changing to
setFloatOnClickand adding the variable works best, plus is consistent with other instances.Requirements
Benefits
Configurations
Related Issues