Skip to content

✨ EVENT_GCODE_AFTER_MPC_TUNE #27865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vovodroid
Copy link
Contributor

Disable steppers after MPC AUTOTUNE finished and Z raised.

@@ -1103,6 +1103,7 @@ void Temperature::factory_reset() {
#endif

do_z_clearance(MPC_TUNING_END_Z, false);
planner.finish_and_disable();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is DEFAULT_STEPPER_TIMEOUT_SEC not working after M306 T?

@vovodroid
Copy link
Contributor Author

vovodroid commented May 18, 2025 via email

@thisiskeithb
Copy link
Member

I guess works, but no harm to disable it explicitly. I just wanted to move head right after tune but found, that it's locked in place, so I added it.

This just leads to an unexpected behavior.

If you want to disable steppers right after MPC Autotune, then it'd be best to make it an option (and a comment explaining the DEFAULT_STEPPER_TIMEOUT_SEC override).

@vovodroid
Copy link
Contributor Author

vovodroid commented May 18, 2025 via email

@thinkyhead thinkyhead added this to the After 2.1.3 milestone May 19, 2025
@thinkyhead
Copy link
Member

thinkyhead commented May 26, 2025

I quickly reworked this as an event with G-code so it can be more flexible. When steppers are disabled the positions will indicate as un-trusted so there is some cue to the user in that case. Not a bad idea to also add an M300 beep at the end of long processes, by preference. We expect a lot of customization and are less worried these days about "non-standard" behavior in a particular customized machine, as long as the mass-shipping machines aren't too quirky. General advice is to provide a slicer profile alongside your machine when you loan or sell it, or revert it to a more vanilla config.

thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request May 26, 2025
@thinkyhead thinkyhead merged commit e9ae520 into MarlinFirmware:bugfix-2.1.x May 27, 2025
132 of 197 checks passed
@thinkyhead thinkyhead changed the title Disable steppers after MPC AUTOTUNE ✨ EVENT_GCODE_AFTER_MPC_TUNE May 27, 2025
@vovodroid vovodroid deleted the mcp-disable-steppers-pr branch May 27, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants