-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
✨ EVENT_GCODE_AFTER_MPC_TUNE #27865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ EVENT_GCODE_AFTER_MPC_TUNE #27865
Conversation
Marlin/src/module/temperature.cpp
Outdated
@@ -1103,6 +1103,7 @@ void Temperature::factory_reset() { | |||
#endif | |||
|
|||
do_z_clearance(MPC_TUNING_END_Z, false); | |||
planner.finish_and_disable(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is DEFAULT_STEPPER_TIMEOUT_SEC
not working after M306 T
?
I guess works, but no harm to disable it explicitly. I just wanted to move head right after tune but found, that it's locked in place, so I added it.
|
This just leads to an unexpected behavior. If you want to disable steppers right after MPC Autotune, then it'd be best to make it an option (and a comment explaining the |
Well, I didn't expect that it remains locked))
|
I quickly reworked this as an event with G-code so it can be more flexible. When steppers are disabled the positions will indicate as un-trusted so there is some cue to the user in that case. Not a bad idea to also add an |
MarlinFirmware/Marlin#27865 Co-Authored-By: Vovodroid <[email protected]>
e9ae520
into
MarlinFirmware:bugfix-2.1.x
Disable steppers after MPC AUTOTUNE finished and Z raised.