Skip to content

Follow up to "Fix ProUI LCD wake up (#27832)" #27835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented May 5, 2025

Description

  • For ProUI - DWIN display types. Ender3-V2 or similar compatibility.

There is a slight issue regarding this... the LCD should come back to full functionality whether the knob is turned or pressed in. Currently, this gives partially functionality; when the screen is off, turning the knob or pressing the button does bring the screen back on, and you can navigate freely (like normal) however, you have to press the knob in (again) in order to work like it did when the screen is on (fully functional).

This aims to make the LCD come back on with a turn of a knob (left or right), or pressing in the knob (enter), and being able to navigate the screen like normal as if the LCD was never off (so the user doesn't have to press the knob in again).

  • Needs testing:

Note

However, while this may fix one thing, this causes another inconvenience, but this PR should also fix that.

So, when a print job is done, and say you print something, and the LCD timer turns the screen off and you come back when it is finished, Turning the knob or pressing in the button will exit the Print Finished screen right away and to the main menu.

By adding if (checkkey != ID_PrintDone) wait_for_user = false;, this should solve that, but testing is needed.

Requirements

ProUI - DWIN / Ender3-V2 LCD

Benefits

Configurations

Related Issues

see NOTE above. testing needed,

  • works!

@thinkyhead thinkyhead merged commit 67948ad into MarlinFirmware:bugfix-2.1.x May 6, 2025
66 checks passed
EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants