Skip to content

limit GRID_MAX_POINTS_[XY] to 2-7 for MESH_BED_LEVELING #27790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Apr 9, 2025

Description

As requested in #27785
Updated sanity checks for GRID_MAX_POINTS_X and GRID_MAX_POINTS_Y when using MESH_BED_LEVELING

There was already an upper limit, but no lower limit.
The upper limit in Config says "Don't use more than 7 points per axis" so I reduced the upper limit to fit the description.

Requirements

MESH_BED_LEVELING + some sort of probe
change GRID_MAX_POINTS_X and or GRID_MAX_POINTS_Y

Benefits

User cannot exceed limits.

Related Issues

  • [BUG] Using one 'GRID_MAX_POINTS' per axis for MESH_BED_LEVELING leads to crash ride #27785
  • @thisiskeithb
    Copy link
    Member

    The upper limit in Config says "Don't use more than 7 points per axis" so I reduced the upper limit to fit the description.

    Perhaps the description should have been updated instead 🙂

    @classicrocker883
    Copy link
    Contributor

    I havent had any issues using 8 or 9 with MESH_BED_LEVELING. Ideally, for Bilinear and UBL I use 7. but that also depends on the probe offset, the bigger the X offset the more limited you can move the printhead to the right side of the bed. however this shouldn't matter using manual leveling because the "probe" is the nozzle, and grid points divide the bed up so all it gives is more points.

    so perhaps the issue depends on the type of printer. I would take that into account.

    @thinkyhead
    Copy link
    Member

    The comment on MBL mesh point limits was added by the original author in 2015 in f34b9c8 and the sanity check in 7dc64ef. Although changes were made to MBL extending the upper limit on points the comments and sanity checks were never changed.

    thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Apr 13, 2025
    @thinkyhead thinkyhead merged commit db42741 into MarlinFirmware:bugfix-2.1.x Apr 13, 2025
    66 checks passed
    @ellensp ellensp deleted the fix-MESH_BED_LEVELING-sanity-check branch April 13, 2025 08:33
    EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request May 15, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    [BUG] Using one 'GRID_MAX_POINTS' per axis for MESH_BED_LEVELING leads to crash ride
    4 participants