add LCD_SERIAL_PORT support to TEENSY40_41 HAL #27736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good followup, thanks! Figured we might as well also do the other Teensy boards and other serial functions, so those are now also included. |
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 15, 2025
Followup to MarlinFirmware#27648 Co-authored-by: Scott Lahteine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Helping out a user on reprap.org to add a display that uses LCD_SERIAL_PORT to his BOARD_TEENSY41
He was using 2.1.2.5 so I added it to that code.
I then decided it would be a good idea to add this to bugfix going forward.
To my surprise I found half of it had already been done in PR #27648
This adds the final missing part to support LCD_SERIAL_PORT on BOARD_TEENSY41 to Marlin/src/HAL/TEENSY40_41/HAL.cpp
Requirements
A BOARD_TEENSY41 and a desire to use a serial display that uses LCD_SERIAL_PORT
Benefits
Builds as expected
Related Issues
https://reprap.org/forum/read.php?415,896633