Fix conditional M81 suicide issue

[zeleps]

Description

Recent changes to M81 implementation omitted invocation of suicide() (where it applies) when powering off conditions are met.

Benefits

Bug fix

Related Issues

#23396

[zeleps]

Also added some serial output messages, mainly for debugging reasons, but it might be sensible to keep some of them, since M81 is not a frequent operation and the messages have an informational value. I don't know what the policy on sending messages over the serial is, I'd like to know more for future contributions.

[thinkyhead]

I'd like to know more for future contributions.

We want to avoid increasing the base build size for the sake of smaller boards with only 64K or 128K of flash, so try to keep messages concise and re-use existing strings whenever possible.

In the future we might use a define like MCU_FLASH_SIZE or have an option like VERBOSITY that will produce a build with more serial messages. Some messages are better to keep hidden unless M111 sets a higher debug level.

Most of the time users are not paying attention to the serial output, so it's not a suitable way to ensure user awareness. Alerts which need user attention or confirmation should use the facilities provided by HOST_PROMPT_SUPPORT. And, we may also want to look at adding standard full-screen modal alerts to MarlinUI.

[ellensp]

@zeleps
Please elaborate on why this was added

#if ENABLED(MKS_PWC)
  #if ENABLED(TFT_LVGL_UI)
    #if ENABLED(PSU_CONTROL)
      #error "PSU_CONTROL is incompatible with MKS_PWC plus TFT_LVGL_UI."
    #endif

It doesn't make much sense

MKS_PWC is a sub define of PSU_CONTROL in Configuration.h. You cannot enable MKS_PWC without first enabling PSU_CONTROL in the current configuration structure.

#if ENABLED(PSU_CONTROL)
  //#define MKS_PWC                 // Using the MKS PWC add-on

[zeleps]

@ellensp I didn't add that, @thinkyhead did at commit 3e0218d.

[ellensp]

@zeleps Sorry I didn't look deep enough, hate how he slips things in like that

[ellensp]

@thinkyhead
Please elaborate on why this was added

#if ENABLED(MKS_PWC)
  #if ENABLED(TFT_LVGL_UI)
    #if ENABLED(PSU_CONTROL)
      #error "PSU_CONTROL is incompatible with MKS_PWC plus TFT_LVGL_UI."
    #endif

It doesn't make much sense

MKS_PWC is a sub define of PSU_CONTROL in Configuration.h. You cannot enable MKS_PWC without first enabling PSU_CONTROL in the current configuration structure.

#if ENABLED(PSU_CONTROL)
  //#define MKS_PWC                 // Using the MKS PWC add-on

This is in relation to issue #23698

[Liriel-666]

Nothing new?

[Liriel-666]

verified? when will it be fixed?

[thisiskeithb]

@Liriel-666: This is a closed (merged) pull request. Pull the latest bugfix if you’re wanting to use this patch.

[Liriel-666]

Äm I tried the latest Bugfix several Minute ago and it doesnt change! The same error that it is not possible to use.
I dont see any changes of the code

[Liriel-666]

In the Bugfix of 2.0.x 01.04.2022 21:34 MET

//
// Power Supply Control
//
#if ENABLED(MKS_PWC)
  #if ENABLED(TFT_LVGL_UI)
    #if ENABLED(PSU_CONTROL)
      #error "PSU_CONTROL is incompatible with MKS_PWC plus TFT_LVGL_UI."
    #endif
    #undef MKS_PWC
    #define SUICIDE_PIN                     PB2
    #define SUICIDE_PIN_STATE               LOW

[Liriel-666]

the error when compiling

In file included from c:\drucker\marlin-bugfix-2.0.x--01.04.22\marlin\src\pins\stm32f4/pins_MKS_ROBIN_NANO_V3.h:72,
                 from c:\drucker\marlin-bugfix-2.0.x--01.04.22\marlin\src\pins\pins.h:675,
                 from c:\drucker\marlin-bugfix-2.0.x--01.04.22\marlin\src\inc\marlinconfig.h:35,
                 from buildroot/share/PlatformIO/scripts/common-dependencies.h:29:
c:\drucker\marlin-bugfix-2.0.x--01.04.22\marlin\src\pins\stm32f4/pins_MKS_ROBIN_NANO_V3_common.h:169:8: error: #error "PSU_CONTROL is incompatible with MKS_PWC plus TFT_LVGL_UI."
  169 |       #error "PSU_CONTROL is incompatible with MKS_PWC plus TFT_LVGL_UI."
      |        ^~~~~
CalledProcessError: Command '"C:\Users\Laen\.platformio\packages\toolchain-gccarmnoneeabi\bin\arm-none-eabi-g++.exe" -D__MARLIN_FIRMWARE__ -DNDEBUG -DHAL_STM32 -DUSBCON -DUSBD_USE_CDC -DTIM_IRQ_PRIO=13 -DADC_RESOLUTION=12 -DPIN_WIRE_SCL=PB6 -DPIN_WIRE_SDA=PB7 -DHAL_PCD_MODULE_ENABLED -D__MARLIN_DEPS__ -w -dM -E -x c++ buildroot/share/PlatformIO/scripts/common-dependencies.h' returned non-zero exit status 1.:   
  File "C:\Users\Laen\.platformio\penv\lib\site-packages\platformio\builder\main.py", line 179:
    env.SConscript(item, exports="env")
  File "C:\Users\Laen\.platformio\packages\tool-scons\scons-local-4.3.0\SCons\Script\SConscript.py", line 597:
    return _SConscript(self.fs, *files, **subst_kw)
  File "C:\Users\Laen\.platformio\packages\tool-scons\scons-local-4.3.0\SCons\Script\SConscript.py", line 285:
    exec(compile(scriptdata, scriptname, 'exec'), call_stack[-1].globals)
  File "C:\drucker\Marlin-bugfix-2.0.x--01.04.22\buildroot\share\PlatformIO\scripts\common-dependencies.py", line 247:
    apply_features_config()
  File "C:\drucker\Marlin-bugfix-2.0.x--01.04.22\buildroot\share\PlatformIO\scripts\common-dependencies.py", line 133:
    if not env.MarlinFeatureIsEnabled(feature):
  File "C:\Users\Laen\.platformio\packages\tool-scons\scons-local-4.3.0\SCons\Util.py", line 742:
    return self.method(*nargs, **kwargs)
  File "C:\drucker\Marlin-bugfix-2.0.x--01.04.22\buildroot\share\PlatformIO\scripts\common-dependencies.py", line 216:
    load_marlin_features()
  File "C:\drucker\Marlin-bugfix-2.0.x--01.04.22\buildroot\share\PlatformIO\scripts\common-dependencies.py", line 204:
    define_list = run_preprocessor(env)
  File "C:\drucker\Marlin-bugfix-2.0.x--01.04.22\buildroot\share\PlatformIO\scripts\preprocessor.py", line 42:
    define_list = subprocess.check_output(cmd, shell=True).splitlines()
  File "C:\Users\Laen\.platformio\python3\lib\subprocess.py", line 424:
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "C:\Users\Laen\.platformio\python3\lib\subprocess.py", line 528:
    raise CalledProcessError(retcode, process.args,

I dont see any change in the Code and in compiling

[stef-ladefense]

please, considere this
#23396 (comment)

[thisiskeithb]

please, considere this
#23396 (comment)

@stef-ladefense: Please create a proper Bug Report or open a PR for review.

[stef-ladefense]

@thisiskeithb
sorry no time, I will be unavailable for at least the next 3 weeks (medical)

[ellensp]

already added PR #25612

[thinkyhead]

Please elaborate on why this was added

It was a modification from a forced setting to an alert. The original code was:

#if ENABLED(MKS_PWC)
  #if ENABLED(TFT_LVGL_UI)
    #undef PSU_CONTROL
    #undef MKS_PWC
    #define SUICIDE_PIN                     PB2
    #define SUICIDE_PIN_STATE               LOW
  #else
    #define PS_ON_PIN                       PB2   // PW_OFF
  #endif
  #define KILL_PIN                          PA2
  #define KILL_PIN_STATE                    HIGH
#endif