Warn of possible endstop/DIAG homing conflicts #23050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisiskeithb
added
F: Calibration
F: Trinamic
Needs: Discussion
thisiskeithb
changed the title
thinkyhead
reviewed
Nov 2, 2021
thinkyhead
force-pushed
the
pr/add_endstop_diag_pin_warning
branch
from
3143365 to
7dfb450
Compare
thinkyhead
force-pushed
the
pr/add_endstop_diag_pin_warning
branch
from
7dfb450 to
9dbfd07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is extremely common to troubleshoot homing issues where users do not remove diag jumpers from the motherboard or do not remove diag pins from drivers when using real endstops, so this PR adds a warning to remind users to do so.
I split the warning into
USES_DIAG_PINSandUSES_DIAG_JUMPERSflags to provide a clearer warning, but they could just as easily be combined and more generalized.Benefits
Users will be alerted to potential homing issues when their motherboard supports sensorless homing via diag signal and they are using real endstops.
Related Issues