Separate serial_index from serial's mask #21287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code that's mixing both concept
rhapsodyv
reviewed
Mar 8, 2021
X-Ryl669
commented
Mar 9, 2021
Vertabreak
added a commit
to Vertabreak/Marlin
that referenced
this pull request
Mar 9, 2021
Distinguish serial index from mask (MarlinFirmware#21287)
vyacheslav-shubin
pushed a commit
to vyacheslav-shubin/Marlin
that referenced
this pull request
Mar 10, 2021
vyacheslav-shubin
pushed a commit
to vyacheslav-shubin/Marlin
that referenced
this pull request
Mar 10, 2021
TyMi
pushed a commit
to TyMi/Marlin
that referenced
this pull request
Mar 11, 2021
* bugfix-2.0.x: (248 commits) [cron] Bump distribution date (2021-03-11) Fix password menu stickiness before first auth (MarlinFirmware#21295) Lerdge-K TMC 2208/9 UART pins (MarlinFirmware#21299) Fix LERDGE 'extends' env references (MarlinFirmware#21305) Fix TouchMI stow in G34 (MarlinFirmware#21291) Fix MeatPack with per-serial-port instances (MarlinFirmware#21306) Tricked-out declaration Update MEATPACK test Number serial from 1 to match settings Clean up spaces and words Fix serial index types Add binary file transfer test fix meat pack internal buffer for multi serial [cron] Bump distribution date (2021-03-10) Fix LPC + TMC boot loop (MarlinFirmware#21298) Distinguish serial index from mask (MarlinFirmware#21287) Host Keepalive followup (MarlinFirmware#21290) [cron] Bump distribution date (2021-03-09) CUSTOM_USER_BUTTONS followup (MarlinFirmware#21284) Fix Host Keepalive serial target (MarlinFirmware#21283) ... # Conflicts: # Marlin/Configuration.h # Marlin/Configuration_adv.h
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 3, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a confusion in the code between
serial_index_tand serial port masks. In some places (like the queue code), aserial_index_tof value -1 is used to mean no output. Yet a serial mask of 0xFF (which is -1) is used to mean output to all ports.Since both were convertible, this leads to subtle bugs.
In this PR, I've created 2 different types:
serial_index_tandSerialMaskand there are not convertible. With this change, the compiler spotted confusing code (in autoreport where a mask was stored in an index variable, and in queue code) so I've fixed those at the same time.Requirements
N/A
Benefits
Have the compiler does its job at spotting errors in the code instead of relying on the developer.
Configurations
N/A
Related Issues
N/A