Skip to content

Move PSU on before setting heating pwm (PID autotune) #19119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Move PSU on before setting heating pwm (PID autotune) #19119

merged 3 commits into from
Aug 24, 2020

Conversation

GMagician
Copy link
Contributor

This should definitively fix #19056

@GMagician GMagician changed the title Move PSU on before setting heating pwm Move PSU on before setting heating pwm (M303) Aug 23, 2020
@GMagician GMagician changed the title Move PSU on before setting heating pwm (M303) Move PSU on before setting heating pwm (PID autotune) Aug 23, 2020
@thisiskeithb thisiskeithb added the Needs: Testing Testing is needed for this change label Aug 23, 2020
@GMagician
Copy link
Contributor Author

@thisiskeithb it seems to work

@thisiskeithb thisiskeithb removed the Needs: Testing Testing is needed for this change label Aug 23, 2020
@thisiskeithb
Copy link
Member

@thisiskeithb it seems to work

It wasn’t confirmed to work by the person that reported it when I added the label. Since it’s been tested and works now, I’ve removed it.

@GMagician
Copy link
Contributor Author

It wasn’t confirmed to work by the person that reported it when I added the label. Since it’s been tested and works now, I’ve removed it.

That's ok, I knew that, I just reported his feedback

@thinkyhead thinkyhead merged commit f67ad6f into MarlinFirmware:bugfix-2.0.x Aug 24, 2020
@GMagician GMagician deleted the Fix-pid-&-PSU branch August 24, 2020 15:10
albertogg pushed a commit to albertogg/Marlin that referenced this pull request Aug 31, 2020
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Sep 2, 2020
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
kageurufu pushed a commit to CR30-Users/Marlin-CR30 that referenced this pull request Apr 30, 2021
thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants