-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
TFT32 screen support on MKS Robin Nano 1.2 board #19031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think TFT_DRIVER and ILI9341_ORIENTATION, and simular settings, should not be defined in this pins_MKS_ROBIN_NANO.h file but instead in configuration.h or configuration_adv.h if possible (there is already a TFT_DRIVER define in configuration.h). |
MKS Robin Nano 1.2. Board can come with TFT32 screen based on ILI9341, for example on Flsun Q5 3d printer. This changes in pins_MKS_ROBIN_NANO.h file will make new style UI work with this board with TFT32 screen. It will work if #define TFT_320x240 is selected in configutation.h and board type is #define MOTHERBOARD BOARD_MKS_ROBIN_NANO
I kind of went the other way, where if |
Sure, I think the same. We are trying to add defaults TFT configs to every board that we can test. Maybe sometimes we forget the In the last weeks we received a lot of TFT support. Now that everything looks like stable, we are working in some refactoring, removing old and duplicated code, and changing some configs to make it easier for the user. In a week or so, I think every option for those 3 new UI will be supported for all TFT. |
I have added I few reviews. I think this PR must be only about add support for TFT32 in nano v1.2. And keep the code about TFT35 as it was, because it's already tested and working. |
This reverts commit ee81a59.
… into bugfix-2.0.x * 'bugfix-2.0.x' of https://github.com/MarlinFirmware/Marlin: (33 commits) Minor cleanup w/r/t LEDs TFT32 for MKS Robin Nano 1.2 (MarlinFirmware#19031) [cron] Bump distribution date (2020-08-24) Feedrate comment (MarlinFirmware#19116) Neopixel => NeoPixel Fix up conditions, comments Fix DUET_SMART_EFFECTOR Consistent static/value item macros [cron] Bump distribution date (2020-08-23) Fix probing margin sanity-check PGMSTR constexpr => const NOZZLE_CLEAN_NO_Y (MarlinFirmware#18870) Change XY_PROBE_SPEED format to (x*60) (MarlinFirmware#18997) Reformat pins files Permit ST7789V orientation override (MarlinFirmware#19044) Prefer Servo AVR timer4 over 3 (MarlinFirmware#19025) DIGIPOT_I2C pins for SMOOTHIEBOARD (MarlinFirmware#19098) Translatable strings on Ender-3 V2 DWIN (MarlinFirmware#19053) HIGH/LOW naming of pin state settings (MarlinFirmware#19089) Update copy_marlin_variant_to_framework.py ...
Description
MKS Robin Nano 1.2. Board can come with TFT32 screen based on ILI9341, for example on Flsun Q5 3d printer. This changes in pins_MKS_ROBIN_NANO.h file will make new style UI work with this board with TFT32 screen. It will work if
#define TFT_320x240
is selected in configutation.h and board type is#define MOTHERBOARD BOARD_MKS_ROBIN_NANO
Benefits
An ability to use sew style UI on MKS Robin Nano 1.2 Board with TFT32 screen (320x240 screen resolution).
Related Issues