Skip to content

Donatello preview integration with nodes. #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Jackymancs4
Copy link

@Jackymancs4 Jackymancs4 commented May 18, 2025

Description

I have implemented two new nodes.

CanvasFromPreview creates a canvas using data from the Paper preference.

TurtleToPreview pipes the turtle input into the preview renderer. That range slider works great.

Fixes #835

Type of change

  • Add two new nodes

How Has This Been Tested?

  • I've created various nodes and graphs. See the screenshot for an example of both nodes used.

java_MXJR6b0YoV

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jackymancs4
Copy link
Author

CanvasFromPreview could use the shift paper setings to set x and y.

TurtleToPreview is not positionin and scaling properly when previewing. When the preview is linked to TurtleToPreview, the "tools" (like "Rotate") do not work, even if donatello is paused. Help needed here.

Turtle turtle1 = this.turtle.getValue();

if(previewPanel != null && turtle1 != null) {
previewPanel.setTurtle(turtle1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this should be setting Makelangelo->setTurtle, which will set the preview panel and allow the other tools (like scale and flip) to work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean MainFrame->setTurtle? Rotation and scaling do indeed works now. Flipping do not. Also do you have ideas for why it appears rotated end flipped by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Donatello to Preview windows integration
2 participants