Skip to content

Preprocessing GUI Page - Data completeness entry html validation incorrect #272

Open
@glycoaddict

Description

@glycoaddict

Describe the bug
In the preprocessing page, "Data completeness across samples cut-off (0.7 -> protein has to be detected in at least 70% of the samples)", the input box only allows either 0 or 1 integer values. However, we need float with a smaller step size.

Verified Fix
Original:

# ...\venv\alphapeptstatsenv\Lib\site-packages\alphastats\gui\pages\03_Preprocessing.py

data_completeness = st.number_input(
    f"Data completeness across samples cut-off \n(0.7 -> protein has to be detected in at least 70% of the samples)",
    value=0, min_value=0, max_value=1
)

Fixed version:

# ...\venv\alphapeptstatsenv\Lib\site-packages\alphastats\gui\pages\03_Preprocessing.py

data_completeness = st.number_input(
    f"Data completeness across samples cut-off \n(0.7 -> protein has to be detected in at least 70% of the samples)",
    value=0.0, min_value=0.0, max_value=1.0, step=0.01,
)

Note:

  1. must be float so use the 0.0 and 1.0 etc
  2. step size should be specified otherwise the html renders as integer of 1.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions