Disable connection URI tests broken by a recent Python fix #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix for python/cpython#105704 broke parsing of URIs containing multiple hosts if one or all of the hosts are IPv6 address literals. This blocks CI, so disable those tests for now until this is fixed properly.
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
May 10, 2025
The `test_connect_params` test is broken due to changes in URI parsing
of multiple hosts containing IPv6 addresses and is temporarily disabled
upstream. Skip the test until it is fixed upstream.
```
____________________ TestConnectParams.test_connect_params _____________________
Traceback (most recent call last):
File "/usr/lib/python3.12/unittest/case.py", line 58, in testPartExecutor
yield
File "/usr/lib/python3.12/unittest/case.py", line 634, in run
self._callTestMethod(testMethod)
File "/usr/lib/python3.12/unittest/case.py", line 589, in _callTestMethod
if method() is not None:
^^^^^^^^
File "/home/buildozer/aports/community/py3-asyncpg/src/asyncpg-0.30.0/tests/test_connect.py", line 1237, in test_connect_params
self.run_testcase(testcase)
File "/home/buildozer/aports/community/py3-asyncpg/src/asyncpg-0.30.0/tests/test_connect.py", line 1154, in run_testcase
addrs, params = connect_utils._parse_connect_dsn_and_args(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildozer/aports/community/py3-asyncpg/src/asyncpg-0.30.0/testenv/lib/python3.12/site-packages/asyncpg/connect_utils.py", line 280, in _parse_connect_dsn_and_args
parsed = urllib.parse.urlparse(dsn)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/urllib/parse.py", line 395, in urlparse
splitresult = urlsplit(url, scheme, allow_fragments)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/urllib/parse.py", line 516, in urlsplit
_check_bracketed_netloc(netloc)
File "/usr/lib/python3.12/urllib/parse.py", line 451, in _check_bracketed_netloc
raise ValueError("Invalid IPv6 URL")
ValueError: Invalid IPv6 URL
```
Upstream issue: MagicStack/asyncpg#1236
Related PR: MagicStack/asyncpg#1244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for python/cpython#105704 broke parsing of URIs containing
multiple hosts if one or all of the hosts are IPv6 address literals.
This blocks CI, so disable those tests for now until this is fixed
properly.