Unify reasoning and reasoningContent fields
#313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the API and hides an unnecessary implementation detail.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the API and hides an unnecessary implementation detail.
What
This PR unifies the
reasoningandreasoning_contentfields into a single publicreasoninggetter.The internal
reasoningandreasoningContentfields are preserved for en- and decoding purposes, to preserve ABI-compatibility and ensure that re-encoding is lossless.Why
As discussed in #311 (comment).
There is no reason to publicly expose both, as only one or neither of these fields will be set at a time.
Affected Areas
ChatResult,ChatStreamResult