Bug: Fix error parsing in StreamInterpreter #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SplittyDev @sakeven for some reason I can't add you as reviewers |
|
Krivoblotsky
approved these changes
Feb 17, 2025
nezhyborets
deleted the
bug/261-streaming-does-not-honor-http-status-codes
branch
wangqi
pushed a commit
to wangqi/OpenAI
that referenced
this pull request
Feb 18, 2025
…honor-http-status-codes Bug: Fix error parsing in StreamInterpreter
wangqi
pushed a commit
to wangqi/OpenAI
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Try parsing APIError on the whole response instead of later on divided pieces
Why
To fix the issue
Affected Areas
StreamInterpreter. Also, while debugging, I added an ability to demo to specify non-streaming way of completing conversations. Didn't add a UI to control that though. Added a task for that #265