Fix nested forms for quizzes #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
development hasn't been used anymore for a long time, instead we always used docker_development and development got outdated.
Note that we replace the byebug gem by debug.
This will allow something like `question[solution_content][dynamic][1,2][content]` for matrix coefficients (note that those are 1-based).
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
fosterfarrell9
requested changes
Jun 10, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fosterfarrell9
previously approved these changes
Jun 10, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #791 +/- ##
=======================================
Coverage 54.33% 54.33%
=======================================
Files 179 179
Lines 7502 7502
=======================================
Hits 4076 4076
Misses 3426 3426 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Merge #790 beforehand.
This is a follow-up to #751 and fixes #788 by reworking the nested params for quizzes. Among others, for the solution content, we introduce a new intermediate layer called "dynamic", sued to render the fields of a matrix, of a tuple or an expression. It can look like this:
Due to the inherent complexity of quizzes, I'm not sure if this fixes them entirely. Please test this thoroughly manually, e.g. play multiple quizzes (where you answer the same question incorrectly, then play it again where you answer it correctly; create new quizzes etc.).