-
Notifications
You must be signed in to change notification settings - Fork 10
Remove download button from vignette videos #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Florian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that controlsList
is an HTML property with limited availability in browsers, e.g. neither Firefox, nor Safari support it. It also does not prevent users from being able to download the video, they can of course still right-click and download it.
With these limitations acknowledged, I approve.
With regards to releasing: we are close to a new regular release, so if you can spare some few more days, we don't have to deploy this as hotfix. So please don't squash-merge just yet and let's discuss the release schedule on Basecamp.
Yes, I am aware of both limitations. Firefox doesn't even display any download button so its mostly for chrome users. Of course we can wait for the next release. Because it doesn't prevent downloading at all, its not really a priority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will squash-merge this, thanks for the PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #774 +/- ##
==========================================
- Coverage 54.21% 54.20% -0.02%
==========================================
Files 178 178
Lines 7490 7490
==========================================
- Hits 4061 4060 -1
- Misses 3429 3430 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is a quick hotfix that removes the download button of the html player for videos displayed in vignettes.