Skip to content

Remove download button from vignette videos #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2025
Merged

Conversation

f-buerckel
Copy link
Collaborator

This is a quick hotfix that removes the download button of the html player for videos displayed in vignettes.

Splines
Splines previously approved these changes May 12, 2025
Copy link
Member

@Splines Splines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that controlsList is an HTML property with limited availability in browsers, e.g. neither Firefox, nor Safari support it. It also does not prevent users from being able to download the video, they can of course still right-click and download it.

With these limitations acknowledged, I approve.


With regards to releasing: we are close to a new regular release, so if you can spare some few more days, we don't have to deploy this as hotfix. So please don't squash-merge just yet and let's discuss the release schedule on Basecamp.

@Splines Splines changed the title remove download button of vignette videos Remove download button from vignette videos May 12, 2025
@f-buerckel
Copy link
Collaborator Author

Yes, I am aware of both limitations. Firefox doesn't even display any download button so its mostly for chrome users. Of course we can wait for the next release. Because it doesn't prevent downloading at all, its not really a priority.

@Splines Splines changed the base branch from main to dev May 18, 2025 16:35
@Splines Splines dismissed their stale review May 18, 2025 16:35

The base branch was changed.

@Splines Splines temporarily deployed to testing-review May 18, 2025 16:37 — with GitHub Actions Inactive
Copy link
Member

@Splines Splines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will squash-merge this, thanks for the PR.

Copy link

codecov bot commented May 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.20%. Comparing base (3084015) to head (4956694).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #774      +/-   ##
==========================================
- Coverage   54.21%   54.20%   -0.02%     
==========================================
  Files         178      178              
  Lines        7490     7490              
==========================================
- Hits         4061     4060       -1     
- Misses       3429     3430       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Splines Splines merged commit 1fce5a9 into dev May 18, 2025
5 checks passed
@Splines Splines deleted the fix/download-button branch May 18, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants