-
Notifications
You must be signed in to change notification settings - Fork 10
Remove food routes #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove food routes #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix deprecation warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #754 +/- ##
======================================
Coverage ? 54.28%
======================================
Files ? 178
Lines ? 7498
Branches ? 0
======================================
Hits ? 4070
Misses ? 3428
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR should be merged after #749.
Important
After you have performed the migrations included in this PR, run
rails solr:reindex
, so that solr obtains the new values for the media sorts (in particular, this needs to be done in production).This PR removes the food routes (that seemed funny when the project was still a little toy project) by serious-looking routes and resolves #456.
Notes
media_types
,media_sorts
,media_names
inapplication_helper.rb
(they are used only in a small number of files) and alsomedium_sort
inlecture.rb
. For PR size reasons and better refereeing experience I decided not to do these refactorizations in this PR; instead they should be part of a later PR.Todo