feat: make binary grid file name configurable #2228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@langevin-usgs I wondered whether this may break expectations in downstream projects, but the default behavior remains the same (input file name plus ".grb"), so I think it should be safe? update: agreed to merge after offline discussion. added warning to release note |
wpbonelli
added a commit
to modflowpy/flopy
that referenced
this pull request
Mar 7, 2025
Necessary as a result of MODFLOW-ORG/modflow6#2228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to all discretization packages to configure the grb output file path, usage
GRB6 OUTFILE <filepath>. Motivated by modflowpy/flopy#2462Checklist of items for pull request
ruffon new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.fprettify