Skip to content

switch to scikit-build-core to avoid setup.py #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 31, 2025

Conversation

nathanhhughes
Copy link
Collaborator

Got around to reworking the packaging to (eventually) work with ros2 with the current package layout. I'm not fully convinced that this works on 20.04, so might be worth starting the ros2 branch off of this

@nathanhhughes
Copy link
Collaborator Author

nathanhhughes commented Mar 25, 2025

Update:

  • It installs on 20.04 (after upgrading pip in the virtual environment)
  • Moving pyproject.toml inadvertently broke ruff (it was using it for settings) in a way that made it hard to restore the isort black profile. I opted for something sane-ish for ruff's import sorting directly, but we can change it if we want
  • I added an optional dependency target for installing (some) of the required SALAD + lightglue deps
  • Instructions are up to date
  • I added COLCON_IGNORE to all the packages. This should stay for ouroboros, but can be dropped once we transition the ros packages Nevermind, catkin also ignores COLCON_IGNORE

Might be worth merging into main after all, I think this doesn't break anything and should be a good ros2 jumping off point

Copy link
Member

@yunzc yunzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nathanhhughes nathanhhughes merged commit 3bbe333 into main Mar 31, 2025
3 checks passed
@nathanhhughes nathanhhughes deleted the feature/scikit_build_backend branch March 31, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants