Skip to content

Fix case-opt WENOs on Frontier #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

ChrisZYJ
Copy link
Contributor

Description

Fixes #534, where assigning ones and zeros to logicals in the generated case-optimized F90 files causes case optimization to not work on Frontier.

It now generates this f90 code intead:

logical, parameter :: wenojs = (0 /= 0)
logical, parameter :: mapped_weno = (0 /= 0)
logical, parameter :: wenoz = (1 /= 0)
logical, parameter :: teno = (0 /= 0)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Scope

  • This PR comprises a set of related changes with a common goal

How Has This Been Tested?

  • Passes WENO test suits
  • Works with case-optimization & generates the expected f90 file

@ChrisZYJ ChrisZYJ marked this pull request as ready for review July 24, 2024 21:15
@ChrisZYJ ChrisZYJ requested a review from sbryngelson as a code owner July 24, 2024 21:15
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.44%. Comparing base (b4dc8ad) to head (4f6e5df).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   58.44%   58.44%           
=======================================
  Files          57       57           
  Lines       14441    14441           
  Branches     1891     1891           
=======================================
  Hits         8440     8440           
  Misses       5440     5440           
  Partials      561      561           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson sbryngelson merged commit 24ea4af into MFlowCode:master Jul 25, 2024
21 of 22 checks passed
AiredaleDev pushed a commit to AiredaleDev/MFC that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Case optimization is broken on Frontier
2 participants