Skip to content

OnSpawnPlayer not called on 1.20.2 and newer #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mfritz2008 opened this issue Apr 10, 2024 · 0 comments
Open

OnSpawnPlayer not called on 1.20.2 and newer #2721

mfritz2008 opened this issue Apr 10, 2024 · 0 comments
Labels
in:protocol-compatibility Related to implementing new Minecraft versions waiting-for:contributor Contributions needed and welcome :)

Comments

@mfritz2008
Copy link

It seems like McClient::OnSpawnPlayer is not being called when connected to servers newer than 1.20.1. Upon further investigation it appears that the SpawnPlayer packet was removed from the protocol in 1.20.2.

See: https://wiki.vg/index.php?title=Protocol&oldid=18389

I'm not familiar enough with Minecraft development to figure out a fix. So please take some time to look into this.

Thanks in advance!

@ReinforceZwei ReinforceZwei added waiting-for:contributor Contributions needed and welcome :) in:protocol-compatibility Related to implementing new Minecraft versions labels Apr 15, 2024
breadbyte added a commit to breadbyte/Minecraft-Console-Client that referenced this issue Jul 13, 2024
breadbyte added a commit to breadbyte/Minecraft-Console-Client that referenced this issue Jul 13, 2024
breadbyte added a commit that referenced this issue Jul 13, 2024
* add miscellaneous fixes

* Fixed connecting to server when compression threshold is set to 0

The client assumes that 0 means disabled, when on a notchian (vanilla) server, it is possible to set the compression threshold to 0 (compress all packets).

* Try to capture all exceptions through Sentry

No exceptions are being logged through Sentry, so be more aggressive when sending exceptions

(cherry picked from commit eb1c2f5)

* Call OnSpawnPlayer packet when a player is spawned using the SpawnEntity packet

references #2721

(cherry picked from commit ef28ae0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:protocol-compatibility Related to implementing new Minecraft versions waiting-for:contributor Contributions needed and welcome :)
Projects
None yet
Development

No branches or pull requests

2 participants