Skip to content

prevent "This method should not be called on the main thread as it may lead to UI unresponsiveness." issue. #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

prevent "This method should not be called on the main thread as it may lead to UI unresponsiveness." issue. #968

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eabe8b2
prevent "This method should not be called on the main thread as it ma…
derjohng Jul 8, 2024
4aea6bf
fix more for "This method can cause UI unresponsiveness if invoked on…
derjohng Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
195 changes: 119 additions & 76 deletions packages/location/ios/Classes/LocationPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,30 +66,39 @@ - (void)initLocation {
- (void)handleMethodCall:(FlutterMethodCall *)call
result:(FlutterResult)result {
[self initLocation];

#ifdef DEBUG // This code will only execute in debug builds
NSLog(@"Flutter method called: %@", call.method);
#endif

if ([call.method isEqualToString:@"changeSettings"]) {
if ([CLLocationManager locationServicesEnabled]) {
CLLocationAccuracy reducedAccuracy = kCLLocationAccuracyHundredMeters;
if (@available(iOS 14, *)) {
reducedAccuracy = kCLLocationAccuracyReduced;
}
NSDictionary *dictionary = @{
@"0" : @(kCLLocationAccuracyKilometer),
@"1" : @(kCLLocationAccuracyHundredMeters),
@"2" : @(kCLLocationAccuracyNearestTenMeters),
@"3" : @(kCLLocationAccuracyBest),
@"4" : @(kCLLocationAccuracyBestForNavigation),
@"5" : @(reducedAccuracy)
};

self.clLocationManager.desiredAccuracy =
[dictionary[call.arguments[@"accuracy"]] doubleValue];
double distanceFilter = [call.arguments[@"distanceFilter"] doubleValue];
if (distanceFilter == 0) {
distanceFilter = kCLDistanceFilterNone;
}
self.clLocationManager.distanceFilter = distanceFilter;
result(@1);
}
dispatch_async(dispatch_get_global_queue( DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^(void)
{
if ([CLLocationManager locationServicesEnabled]) {
CLLocationAccuracy reducedAccuracy = kCLLocationAccuracyHundredMeters;
if (@available(iOS 14, *)) {
reducedAccuracy = kCLLocationAccuracyReduced;
}
NSDictionary *dictionary = @{
@"0" : @(kCLLocationAccuracyKilometer),
@"1" : @(kCLLocationAccuracyHundredMeters),
@"2" : @(kCLLocationAccuracyNearestTenMeters),
@"3" : @(kCLLocationAccuracyBest),
@"4" : @(kCLLocationAccuracyBestForNavigation),
@"5" : @(reducedAccuracy)
};

self.clLocationManager.desiredAccuracy =
[dictionary[call.arguments[@"accuracy"]] doubleValue];
double distanceFilter = [call.arguments[@"distanceFilter"] doubleValue];
if (distanceFilter == 0) {
distanceFilter = kCLDistanceFilterNone;
}
self.clLocationManager.distanceFilter = distanceFilter;
result(@1);
}
});

} else if ([call.method isEqualToString:@"isBackgroundModeEnabled"]) {
if (self.applicationHasLocationBackgroundMode) {
if (@available(iOS 9.0, *)) {
Expand All @@ -112,36 +121,52 @@ - (void)handleMethodCall:(FlutterMethodCall *)call
result(@0);
}
} else if ([call.method isEqualToString:@"getLocation"]) {
if (![CLLocationManager locationServicesEnabled]) {
result([FlutterError
errorWithCode:@"SERVICE_STATUS_DISABLED"
message:@"Failed to get location. Location services disabled"
details:nil]);
return;
}
if ([CLLocationManager authorizationStatus] ==
kCLAuthorizationStatusDenied) {
// Location services are requested but user has denied
NSString *message =
@"The user explicitly denied the use of location services for this "
"app or location services are currently disabled in Settings.";
result([FlutterError errorWithCode:@"PERMISSION_DENIED"
message:message
details:nil]);
return;
}

self.flutterResult = result;
self.locationWanted = YES;

if ([self isPermissionGranted]) {
[self.clLocationManager startUpdatingLocation];
} else {
[self requestPermission];
if ([self isPermissionGranted]) {
[self.clLocationManager startUpdatingLocation];
}
}
// Dispatch startUpdatingLocation to a background thread
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
if (![CLLocationManager locationServicesEnabled]) {
result([FlutterError errorWithCode:@"SERVICE_STATUS_DISABLED"
message:@"Failed to get location. Location services disabled"
details:nil]);

return;
}

// Handle authorization status and accuracy for iOS 14+
if (@available(iOS 14, *)) {
CLAuthorizationStatus status = self.clLocationManager.authorizationStatus;
CLAccuracyAuthorization accuracy = self.clLocationManager.accuracyAuthorization;

// Check for denied permission or reduced accuracy with explicit denial
if (status == kCLAuthorizationStatusDenied ||
(accuracy == CLAccuracyAuthorizationReducedAccuracy && status == kCLAuthorizationStatusRestricted)) {

NSString *message = @"Location services denied. Please enable them in settings.";
result([FlutterError errorWithCode:@"PERMISSION_DENIED" message:message details:nil]);
return;
}

// If permission not determined yet or reduced accuracy without explicit denial
if (status == kCLAuthorizationStatusNotDetermined || accuracy == CLAccuracyAuthorizationReducedAccuracy) {
// Request permission - this will trigger the delegate method
[self requestPermission]; // This will handle starting location updates in the delegate
return;
}
} else {
// Fallback for older iOS versions
if ([CLLocationManager authorizationStatus] == kCLAuthorizationStatusDenied) {
NSString *message = @"The user explicitly denied the use of location services for this "
"app or location services are currently disabled in Settings.";
result([FlutterError errorWithCode:@"PERMISSION_DENIED" message:message details:nil]);
return;

}
}

// Permission is granted, proceed
self.flutterResult = result;
self.locationWanted = YES;
[self.clLocationManager startUpdatingLocation];
});
} else if ([call.method isEqualToString:@"hasPermission"]) {
if ([self isPermissionGranted]) {
result([self isHighAccuracyPermitted] ? @1 : @3);
Expand All @@ -160,17 +185,23 @@ - (void)handleMethodCall:(FlutterMethodCall *)call
result(@2);
}
} else if ([call.method isEqualToString:@"serviceEnabled"]) {
if ([CLLocationManager locationServicesEnabled]) {
result(@1);
} else {
result(@0);
}
dispatch_async(dispatch_get_global_queue( DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^(void)
{
if ([CLLocationManager locationServicesEnabled]) {
result(@1);
} else {
result(@0);
}
});

} else if ([call.method isEqualToString:@"requestService"]) {
if ([CLLocationManager locationServicesEnabled]) {
result(@1);
} else {
dispatch_async(dispatch_get_global_queue( DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^(void)
{
if ([CLLocationManager locationServicesEnabled]) {
result(@1);
} else {
#if TARGET_OS_OSX
NSAlert *alert = [[NSAlert alloc] init];
NSAlert *alert = [[NSAlert alloc] init];
[alert setMessageText:@"Location is Disabled"];
[alert setInformativeText:
@"To use location, go to your System Preferences > Security & "
Expand All @@ -188,17 +219,19 @@ - (void)handleMethodCall:(FlutterMethodCall *)call
}
}];
#else
UIAlertView *alert = [[UIAlertView alloc]
initWithTitle:@"Location is Disabled"
message:@"To use location, go to your Settings App > "
@"Privacy > Location Services."
delegate:self
cancelButtonTitle:@"Cancel"
otherButtonTitles:nil];
[alert show];
UIAlertView *alert = [[UIAlertView alloc]
initWithTitle:@"Location is Disabled"
message:@"To use location, go to your Settings App > "
@"Privacy > Location Services."
delegate:self
cancelButtonTitle:@"Cancel"
otherButtonTitles:nil];
[alert show];
#endif
result(@0);
}
result(@0);
}
});

} else {
result(FlutterMethodNotImplemented);
}
Expand Down Expand Up @@ -289,7 +322,9 @@ - (FlutterError *)onListenWithArguments:(id)arguments
self.flutterListening = YES;

if ([self isPermissionGranted]) {
[self.clLocationManager startUpdatingLocation];
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
[self.clLocationManager startUpdatingLocation];
});
} else {
[self requestPermission];
}
Expand Down Expand Up @@ -357,7 +392,10 @@ - (void)locationManager:(CLLocationManager *)manager
}

if (self.locationWanted || self.flutterListening) {
[self.clLocationManager startUpdatingLocation];
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
[self.clLocationManager startUpdatingLocation];
});

}
} else if (@available(macOS 10.12, *)) {
if (status == kCLAuthorizationStatusAuthorizedAlways) {
Expand All @@ -367,7 +405,10 @@ - (void)locationManager:(CLLocationManager *)manager
}

if (self.locationWanted || self.flutterListening) {
[self.clLocationManager startUpdatingLocation];
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
[self.clLocationManager startUpdatingLocation];
});

}
}
}
Expand All @@ -380,7 +421,9 @@ - (void)locationManager:(CLLocationManager *)manager
}

if (self.locationWanted || self.flutterListening) {
[self.clLocationManager startUpdatingLocation];
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
[self.clLocationManager startUpdatingLocation];
});
}
}
#endif
Expand Down