Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1035
Migrated from deprecated
LocationRequest
toPriority
Priority doesn't have a PRIORITY_NO_POWER property, according to its documentation we should use PRIORITY_PASSIVE
LocationRequest.PRIORITY_NO_POWER
->Priority.PRIORITY_PASSIVE
On SDK 31+
location.isFromMockProvider()
is deprecated, but older versions of android still uses it, so we have to annotate the method with@SuppressWarnings("deprecation")
If the project is running sdk 31+ we use
location.isMock()
, otherwise we fallback tolocation.isFromMockProvider()
For the
LocationRequest.create()
we have to use the new builderLocationRequest.Builder()
. The parameters are passed to the builder, and not the mLocationRequest directlyThe
new Long()
andnew Float()
were migrated toNumber
, and manipulated so we could have a proper Long and Float valuesIf I missed something, please point it out so I can fix it