Skip to content

feat: nanoGPT implementation using Reactant #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Nov 9, 2024

Needs

error: could not compute the adjoint for this operation %51 = "stablehlo.dynamic_gather"(%15, %0, %12) <{dimension_numbers = #stablehlo.gather<offset_dims = [0], collapsed_slice_dims = [1], start_index_map = [1], index_vector_dim = 1>}> : (tensor<64x64xf32>, tensor<64xi64>, tensor<2xi64>) -> tensor<64x64xf32>
error: could not compute the adjoint for this operation %47 = "stablehlo.dynamic_gather"(%14, %46, %12) <{dimension_numbers = #stablehlo.gather<offset_dims = [0], collapsed_slice_dims = [1], start_index_map = [1], index_vector_dim = 1>}> : (tensor<64x67xf32>, tensor<8192xi64>, tensor<2xi64>) -> tensor<64x8192xf32>
ERROR: LoadError: "failed to run pass manager on module"

@avik-pal avik-pal marked this pull request as draft November 9, 2024 02:19
@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch 4 times, most recently from 844a274 to d2e7299 Compare November 15, 2024 02:58
@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch 2 times, most recently from f4504bc to 9b97721 Compare November 16, 2024 18:53
@avik-pal avik-pal requested a review from Copilot December 11, 2024 14:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • examples/NanoGPT/main.jl: Language not supported

@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch from 9b97721 to 6359fdb Compare February 7, 2025 21:43
@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch from 386963b to 2dc6742 Compare May 23, 2025 00:08
@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch from 24e71cd to 0103f95 Compare May 23, 2025 21:34
Copy link
Contributor

github-actions bot commented May 23, 2025

Benchmark Results (ASV)

main b508bb4... main / b508bb4...
basics/overhead 0.135 ± 0.0013 μs 0.13 ± 0.0023 μs 1.04 ± 0.021
time_to_load 0.873 ± 0.0064 s 0.878 ± 0.0081 s 0.994 ± 0.012

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch from b508bb4 to f64885f Compare May 30, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants