[WIP] new render implementation at src/writer.jl:549 #259
Conversation
|
@asinghvi17 please review. meanwhile I am trying to figure out how i can test this |
|
I would just add it to the DocumenterVitepress docs, we don't actually have tests at the moment 😅 |
|
okay. i might try to run my own test. I am sure I made some mistake |
src/writer.jl
Outdated
| _print(io, "\\t"^(level-1) * "[", id, "](") | ||
| latex(io, header.children) | ||
| _println(io, ")") |
There was a problem hiding this comment.
This is the other way around I think, we need the logic from
anchor_frag = Documenter.anchor_fragment(anchor)
anchor_frag = vitepress_anchor(anchor_frag)
url = replace(string(path, anchor_frag), " " => "%20")
and the underscores can be dropped from _print and _println.
It may be worth sticking to the original approach for the rendering here but we keep the rendering header.children instead. You can check what we do for lists in writer.jl to see how to do that inline. Since we need to strip the Markdown it may be nice to have the Markdown.plaininline stuff.
There was a problem hiding this comment.
can you put that in as a suggested change? sorry for the inconvenience
fixes #237