Skip to content

The current SudoswapProxy implementation cannot handle partial fills when an NFT is no longer available #26

Open
@0xhiroshi

Description

@0xhiroshi

The current SudoswapProxy's partial fill can only handle the case where the pool price moves out of the user's max cost. It will revert during safeTransferFrom if the NFT the user wants to purchase is no longer available.

Sudoswap will release a V2 router and it will be able to handle this scenario by checking that the token IDs are still in the pool before order execution, so we will wait until it goes live before integrating with Sudoswap again.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions