OSOE-430: Support a single NE instance per solution on Linux, too, in Lombiq.NodeJs.Extensions #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the last commit (6d8e166) that contains the fixes to various ESlint warnings, including some that aren't related to this issue. (because the auxiliary scripts in Lombiq.NodeJs.Extensions/scripts/ that are only used by node during the compilation don't get linted automatically) |
dministro
requested changes
Oct 17, 2023
| @@ -26,7 +27,8 @@ async function copyFilesFromConfig(config) { | |||
| return Promise.all(config | |||
| .map((assetsGroup) => assetsGroup.sources.map((assetSource) => { | |||
| // Normalize the relative path to the directory to remove trailing slashes and straighten out any anomalies. | |||
| const directoryToCopy = path.normalize(assetSource); | |||
| const projectPath = getProjectDirectory(); | |||
| const directoryToCopy = path.normalize(path.join(projectPath, assetSource)); | |||
There was a problem hiding this comment.
path.resolve() seems a better choice to me instead of path.join() in case of absolute assetSource
| const sourceAndTargetPaths = [pathPattern, assetsGroup.target]; | ||
| const targetPath = (process.platform === 'win32') | ||
| ? assetsGroup.target | ||
| : path.normalize(path.join(projectPath, assetsGroup.target)); |
There was a problem hiding this comment.
path.resolve() same reason like above.
Co-authored-by: József Horváth <[email protected]>
dministro
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-430
Fixes #17