Skip to content

Refactor CI with Reusable Workflow #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

Refactor CI with Reusable Workflow #123

merged 2 commits into from
May 6, 2025

Conversation

Locietta
Copy link
Owner

@Locietta Locietta commented May 6, 2025

Use a reusable workflow file to de-duplicate the workflow logic.

By centralizing the workflow configuration, we reduce the risk of errors when updating workflows, especially as we will also add RT branch (#88), manually copying changes across multiple workflow files can be really error-prone.


Zen3 build is also added here, so we now also have a AMD-specific build. The benefit is still not clear, but in case someone would like to try, I decide to add it.

FYI: We can check each uarch's ability at https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html. From what I can tell, znver3 does mean a little more than x86-64-v3. But the difference between znver3 and znver4 is just some AVX512 capabilities (which is proved no benefit in kernel), so I don't bother to add the latter.

Locietta added 2 commits May 6, 2025 10:21
So we don't need to copy changes across workflow files.
@Locietta Locietta marked this pull request as ready for review May 6, 2025 12:08
@Locietta Locietta changed the title [WIP] Refactor CI with Reusable Workflow Refactor CI with Reusable Workflow May 6, 2025
@Locietta Locietta merged commit f3599b2 into main May 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant