Skip to content

[REFACTOR] Fix Firefox icon, new Glow theme, bug fixes, refactors, and more #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Oct 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
2f3b89b
:zap: Include the index in item ID
Lissy93 Oct 10, 2021
cff537b
:boom: (#177) Depricates old auth struct
Lissy93 Oct 10, 2021
894b719
:lipstick: Updates min footer-height, to prevent scrollbar visible
Lissy93 Oct 10, 2021
75ba48a
:raising_hand_man: Updates Support docs
Lissy93 Oct 10, 2021
481072f
:hibiscus: Normalizes syntax in pr-badge yaml config
Lissy93 Oct 10, 2021
c5d30f9
:alien: Updates the initial, main config file
Lissy93 Oct 10, 2021
ca203bb
:memo: Small docs changes
Lissy93 Oct 10, 2021
e355680
:lipstick: Adds new soft glow light theme
Lissy93 Oct 10, 2021
7e4e2ed
:bento: Adds missing Firefix favicons (#163)
Lissy93 Oct 10, 2021
e971a0b
:lipstick: Hover color on description text of colorful theme
Lissy93 Oct 10, 2021
5fe7971
:zap: If only 1 section set, then expand on load
Lissy93 Oct 10, 2021
987f904
:iphone: Navbar show/ hide functionality on mobile
Lissy93 Oct 11, 2021
27a4f9f
:iphone: Improved mobile responsivness for quick-settings
Lissy93 Oct 11, 2021
6bd6a5a
:iphone: Quick-settings hidden by default on mobile
Lissy93 Oct 11, 2021
0bee487
:iphone: Improved splash screen for mobile devices
Lissy93 Oct 11, 2021
1298910
:bug: (#274) Fixes relaive icon fetching, when base_url used
Lissy93 Oct 11, 2021
67b0e69
:pencil2: Fixes typo in App Version translation key
Lissy93 Oct 11, 2021
a21dc50
:iphone: Ignore custom grid, when on tiny screen/ mobile
Lissy93 Oct 11, 2021
51789f8
:iphone: Improved responsivness for large items with grid layout
Lissy93 Oct 12, 2021
25a9751
:pirate_flag: Adds Ye Pirate Speak
Lissy93 Oct 12, 2021
f95b306
:arrow_up: Updates dependencies
Lissy93 Oct 12, 2021
fffa231
:sparkles: Implements router history mode, for cleaner URLs
Lissy93 Oct 13, 2021
d79b2d1
βž• Adds connect-history-api-fallback for history routing
Lissy93 Oct 13, 2021
96a0d62
:memo: Adds guides on automated backups, updating, healthcecks, perfo…
Lissy93 Oct 13, 2021
7896390
:memo: Adds secure container management docs
Lissy93 Oct 14, 2021
79ee999
:hammer: Updates anti-spam action to not run for feedback
Lissy93 Oct 15, 2021
ff47cd2
:bento: Adds a back-button icon asset
Lissy93 Oct 15, 2021
9270b85
:sparkles: Builds single-section view
Lissy93 Oct 15, 2021
a45887f
:adhesive_bandage: Fix text overflow on small items
Lissy93 Oct 15, 2021
050b3a1
:lipstick: Update built-in themes
Lissy93 Oct 15, 2021
59c0655
:adhesive_bandage: Fix syntax in assign-reviewer workflow
Lissy93 Oct 15, 2021
9578d5f
:memo: Updates docs
Lissy93 Oct 15, 2021
0c8a901
:bookmark: Bumps to V 1.8.7 and updates changelog
Lissy93 Oct 15, 2021
41dd3fe
:arrow_up: Upgrades critical dependencies
Lissy93 Oct 15, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Changelog

## ⚑️ 1.8.7 - Bug Fixes and Improvements [PR #273](https://github.com/Lissy93/dashy/pull/273)
- Clean URLs without the hash, now using history-mode routing
- New initial main example conf.yml
- Minor UI style updates and fixes
- Support for single section view
- A new theme, soft-glow
- Container security in management docs, and other things
- Bug fixes, including missing Firefox favicon and fix custom icon paths with base_url

## ⚑️ 1.8.6 - Implementation of VueX [PR: #271](https://github.com/Lissy93/dashy/pull/271)
- New state management pattern, which should lead to a more organized code base long term, and will also make building out the new UI editor significantly easier to do in a clean and reliable way

Expand Down
12 changes: 9 additions & 3 deletions .github/SUPPORT.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
# Support

To raise a bug, please **[Open a new Issue](https://github.com/Lissy93/dashy/issues/new/choose)**.
To report a potential vulnerability, follow the steps in **[Security](https://github.com/Lissy93/dashy/blob/master/.github/SECURITY.md#reporting-a-security-issue)**.

To report a potential vulnerability, please see **[Security](https://github.com/Lissy93/dashy/blob/master/.github/SECURITY.md#reporting-a-security-issue)**.
For setup and usage guides, see **[dashy.to/docs](https://dashy.to/)** or the **[GitHub](https://github.com/Lissy93/dashy)** repo.

To raise a bug, for something that's not working, **[Open a new Issue](https://github.com/Lissy93/dashy/issues/new/choose)**.

For help with getting Dashy up and running, please see the **[Discussions](https://github.com/Lissy93/dashy/discussions)**.

If you'd like to help support Dashy's future development, see **[Contributing](https://github.com/Lissy93/dashy/blob/master/docs/contributing.md)**.
If you'd like to help support Dashy's future development, see **[Contributing](https://github.com/Lissy93/dashy/blob/master/docs/contributing.md)**.

To get in contact with the author, email me at **`alicia at omg dot lol`** **[[PGP]](https://keybase.io/aliciasykes/pgp_keys.asc?fingerprint=0688f8d34587d954e9e51fb8fedb68f55c0283a7)**.

-Thank you
246 changes: 123 additions & 123 deletions .github/pr-badge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,144 +2,144 @@
# Dynamically inserts status badges into PR description, based on certain conditions

# Checks if the required sections are missing
- label: "⚠️Missing"
message: "Category"
color: "#f25265"
when: "$payload.pull_request.body.includes('Category') === false"
- label: "⚠️Missing"
message: "Overview"
color: "#f25265"
when: "$payload.pull_request.body.includes('Overview') === false"
- label: "⚠️Missing"
message: "Quality Checklist"
color: "#f25265"
when: "$payload.pull_request.body.includes('Code Quality Checklist') === false"
- label: "⚠️Description"
message: "Incomplete"
color: "#f25265"
when: "$payload.pull_request.body.length < 25"
- label: "⚠️Missing"
message: "Label"
color: "#f25265"
when: "$labels.length == 0"
- label: ⚠️Missing
message: Category
color: '#f25265'
when: $payload.pull_request.body.includes('Category') === false
- label: ⚠️Missing
message: Overview
color: '#f25265'
when: $payload.pull_request.body.includes('Overview') === false
- label: ⚠️Missing
message: Quality Checklist
color: '#f25265'
when: $payload.pull_request.body.includes('Code Quality Checklist') === false
- label: ⚠️Description
message: Incomplete
color: '#f25265'
when: $payload.pull_request.body.length < 25
- label: ⚠️Missing
message: Label
color: '#f25265'
when: $labels.length == 0

# Show note when task list has unfinished items
- label: "⚠️Notice"
message: "Unchecked Tasks"
when: "$payload.pull_request.body.includes('- [ ] ')"
color: "#f25265"
- label: ⚠️Notice
message: Unchecked Tasks
when: $payload.pull_request.body.includes('- [ ] ')
color: '#f25265'

# Show badge indicating PR status
- label: "Status"
message: "✏️ Draft"
when: "$isDraft"
color: "#ffa933"
- label: "Status"
message: "🧱 Work in Progress"
when: "$payload.pull_request.title.includes('WIP')"
color: "#29e3f4"
- label: "Status"
message: "βœ… Ready"
color: "#3ef963"
when: "$labels.includes('πŸ”€ Ready for Merge')"
- label: Status
message: ✏️ Draft
when: $isDraft
color: '#ffa933'
- label: Status
message: 🧱 Work in Progress
when: $payload.pull_request.title.includes('WIP')
color: '#29e3f4'
- label: Status
message: βœ… Ready
color: '#3ef963'
when: $labels.includes('πŸ”€ Ready for Merge')

# Add size label based on very large or tiny PRs
- label: "PR Size"
message: "Extra Large"
color: "#f9833e"
when: "$additions > 1000"
- label: "PR Size"
message: "Large"
color: "#f4b546"
when: "$additions > 500 && $additions < 1000"
- label: "PR Size"
message: "Medium"
color: "#f3ff59"
when: "$additions > 10 && $additions < 500"
- label: "PR Size"
message: "Quick"
color: "#3eef8b"
when: "$additions < 10"
- label: PR Size
message: Extra Large
color: '#f9833e'
when: '$additions > 1000'
- label: PR Size
message: Large
color: '#f4b546'
when: '$additions > 500 && $additions < 1000'
- label: PR Size
message: Medium
color: '#f3ff59'
when: '$additions > 10 && $additions < 500'
- label: PR Size
message: Quick
color: '#3eef8b'
when: '$additions < 10'

# Show PR number, to destination and from destination
- label: "#$prNumber"
message: "$payload.pull_request.user.login /$payload.pull_request.head.ref β†’ $payload.repository.full_name"
color: "#ab5afc"
url: "https://github.com/$slug/tree/$branchName"
- label: '#$prNumber'
message: '$payload.pull_request.user.login /$payload.pull_request.head.ref β†’ $payload.repository.full_name'
color: '#ab5afc'
url: 'https://github.com/$slug/tree/$branchName'

# Show total code added minus deleted
- label: "New Code"
message: "Commits: $payload.pull_request.commits | Files Changed: $payload.pull_request.changed_files | Additions: $payload.pull_request.additions-$payload.pull_request.deletions"
color: "#dddd00"
- label: New Code
message: 'Commits: $payload.pull_request.commits | Files Changed: $payload.pull_request.changed_files | Additions: $payload.pull_request.additions-$payload.pull_request.deletions'
color: '#dddd00'

# Show submitting user's username and profile link
- label: πŸ’• Submitted by
message: "$payload.pull_request.user.login"
color: "#f73ae6"
when: "$payload.pull_request.author_association !== 'OWNER'"
url: "https://github.com/$payload.pull_request.user.login"
message: $payload.pull_request.user.login
color: '#f73ae6'
when: $payload.pull_request.author_association !== 'OWNER'
url: 'https://github.com/$payload.pull_request.user.login'

# Show a badge indicating the PR category, based on tag
- label: "Type"
message: "✨ Feature"
color: "#39b0fd"
when: "$labels.includes('✨ New Feature')"
- label: "Type"
message: "πŸ› Fix"
color: "#39b0fd"
when: "$labels.includes('πŸ¦‹ Bug Fix')"
- label: "Type"
message: "πŸ“• Docs"
color: "#39b0fd"
when: "$labels.includes('πŸ“• Docs')"
- label: "Type"
message: "πŸ› οΈ Build Changes"
color: "#39b0fd"
when: "$labels.includes('πŸ› οΈ Build Changes')"
- label: "Type"
message: "πŸ› οΈ Build Changes"
color: "#39b0fd"
when: "$labels.includes('πŸ› οΈ Build Changes')"
- label: "Type"
message: "🚚 Refactor"
color: "#39b0fd"
when: "$labels.includes('🚚 Refactor')"
- label: "Type"
message: "πŸ’„ Stylistic Changes"
color: "#39b0fd"
when: "$labels.includes('πŸ’„ Stylistic Changes')"
- label: "Type"
message: "🌟 Showcase Addition"
color: "#39b0fd"
when: "$labels.includes('πŸ’― Showcase')"
- label: "Type"
message: "πŸ—οΈ Architecture"
color: "#39b0fd"
when: "$labels.includes('πŸ—οΈ Architectural Changes')"
- label: "Type"
message: "πŸ€– Auto Submission"
color: "#39b0fd"
when: "$labels.includes('πŸ€– Auto')"
- label: "Type"
message: "🌐 Language Update"
color: "#39b0fd"
when: "$labels.includes('🌐 Language')"
- label: Type
message: ✨ Feature
color: '#39b0fd'
when: $labels.includes('✨ New Feature')
- label: Type
message: πŸ› Fix
color: '#39b0fd'
when: $labels.includes('πŸ¦‹ Bug Fix')
- label: Type
message: πŸ“• Docs
color: '#39b0fd'
when: $labels.includes('πŸ“• Docs')
- label: Type
message: πŸ› οΈ Build Changes
color: '#39b0fd'
when: $labels.includes('πŸ› οΈ Build Changes')
- label: Type
message: πŸ› οΈ Build Changes
color: '#39b0fd'
when: $labels.includes('πŸ› οΈ Build Changes')
- label: Type
message: 🚚 Refactor
color: '#39b0fd'
when: $labels.includes('🚚 Refactor')
- label: Type
message: πŸ’„ Stylistic Changes
color: '#39b0fd'
when: $labels.includes('πŸ’„ Stylistic Changes')
- label: Type
message: 🌟 Showcase Addition
color: '#39b0fd'
when: $labels.includes('πŸ’― Showcase')
- label: Type
message: πŸ—οΈ Architecture
color: '#39b0fd'
when: $labels.includes('πŸ—οΈ Architectural Changes')
- label: Type
message: πŸ€– Auto Submission
color: '#39b0fd'
when: $labels.includes('πŸ€– Auto')
- label: Type
message: 🌐 Language Update
color: '#39b0fd'
when: $labels.includes('🌐 Language')

# Show warning, when certain tags are applied
- label: "Warning"
message: "β›” Do Not Merge"
color: "#f25265"
when: "$labels.includes('β›” Don't Merge')"
- label: "Warning"
message: "🚫 Merge Conflicts"
color: "#f25265"
when: "$labels.includes('🚫 Merge Conflicts')"
- label: "Warning"
message: "πŸ•ΈοΈ Inactive"
color: "#f25265"
when: "$labels.includes('πŸ•ΈοΈ Inactive')"
- label: "Warning"
message: "πŸ’€ Spam"
color: "#f25265"
when: "$labels.includes('πŸ’€ Spam')"
- label: Warning
message: β›” Do Not Merge
color: '#f25265'
when: $labels.includes("β›” Don't Merge")
- label: Warning
message: 🚫 Merge Conflicts
color: '#f25265'
when: $labels.includes('🚫 Merge Conflicts')
- label: Warning
message: πŸ•ΈοΈ Inactive
color: '#f25265'
when: $labels.includes('πŸ•ΈοΈ Inactive')
- label: Warning
message: πŸ’€ Spam
color: '#f25265'
when: $labels.includes('πŸ’€ Spam')

7 changes: 4 additions & 3 deletions .github/workflows/assign-reviewer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ jobs:
assign-author:
runs-on: ubuntu-latest
steps:
- name: Assign author
uses: technote-space/assign-author@v1
GITHUB_TOKEN: ${{secrets.BOT_GITHUB_TOKEN}}
- name: Assign author
uses: technote-space/assign-author@v1
with:
GITHUB_TOKEN: ${{ secrets.BOT_GITHUB_TOKEN }}
7 changes: 6 additions & 1 deletion .github/workflows/issue-spam-control.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@ on:
types: [opened, reopened]
jobs:
check-user:
if: ${{ ! contains( github.event.issue.labels.*.name, 'keep-open') && github.event.comment.author_association != 'CONTRIBUTOR' }}
if: >
${{
! contains( github.event.issue.labels.*.name, 'πŸ“Œ Keep Open') &&
! contains( github.event.issue.labels.*.name, '🌈 Feedback') &&
github.event.comment.author_association != 'CONTRIBUTOR'
}}
runs-on: ubuntu-latest
name: Close issue opened by non-stargazer
steps:
Expand Down
Loading