✨ Feature: add user defined environment variables

[zigotica]

Category:
Feature

Overview
Add user defined environment vars parser to avoid leaking secrets

Code Quality Checklist (Please complete)

• All changes are backwards compatible
• All lint checks and tests are passing
• There are no (new) build warnings or errors
• Bumps version, if new feature added

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashy	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 15, 2024 5:59pm

[netlify]

✅ Deploy Preview for dashy-dev ready!

Name	Link
🔨 Latest commit	e818c70
🔍 Latest deploy log	https://app.netlify.com/sites/dashy-dev/deploys/65a572224614b2000855a03c
😎 Deploy Preview	https://deploy-preview-1438--dashy-dev.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[zigotica]

Hi @Lissy93 Thank you so much for this great dashboard!
I added documentation and example for pihole widget, we can extend this to any other widget very easily. Hope you like it.

[zigotica]

Hi again @Lissy93 Sorry I haven't seen your reaction to first message, had a traffic accident and still under recovery. Apparently you seemed fond of the feature.

When I can be back, would you still be interested in me fixing the conflicts? Please be aware, they seem to be caused by a strange spacing in your text files. I can either remove my documentation changes and keep your files, or "fix" them (but they will actually bring more spacing issues if the MR takes long to be merged).

Also, would you be interested in me applying the same approach in other widgets?

[Lissy93]

Hey @zigotica - sorry to hear about your traffic accident, are you recovering okay??

Your PR looks awesome, and is definitely the correct approach.

Let me finish off #1528, then I'll rebase your PR and get it merged :)

And sorry for the delay in responding, this totally slipped my mind.

[Lissy93]

Actually, would you be able to switch the target branch for your PR into FEAT/Dashy-V3? That way I can get it released sooner.
Alternatively, I can just copy your changes over to that branch, if you're happy for me to do so

[zigotica]

Hi again @Lissy93
I´m recovering slower than I expected, but all good, thank you.
I just changed the target branch as you suggested

[zigotica]

Also, I am happy if you change what you need, not sure I'll be able to follow up this thread soon-ish. A pity cause I think it was going to be quite easy to update the rest of the widgets, I am happy if you continue the job (if you want) or I can do it when I am fully recovered (it can be some weeks)

[Lissy93]

Well I'm wishing you all the best with your recovery 🌼🤗🧡

I've merged into the 3.0 branch, and will let you know once available in master- shouldn't be too long!