Skip to content
This repository was archived by the owner on Feb 17, 2021. It is now read-only.

Add error callback for showStep (Issue #274) #291

Merged
merged 8 commits into from
Jun 26, 2016
Merged

Add error callback for showStep (Issue #274) #291

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6ac3a70
Add error callback for showStep
travstone Jun 24, 2016
191048c
Revert step num after error callback
travstone Jun 24, 2016
ffa1a3e
remove all stepNum stuff, see if it still breaks
travstone Jun 24, 2016
8dfed46
Add templates stuff
travstone Jun 24, 2016
652e877
Revert "Add templates stuff"
travstone Jun 25, 2016
27f6d73
Resubmit error callback patch
travstone Jun 25, 2016
96091ea
deglobalizing temporary var
travstone Jun 25, 2016
b30cc25
Hoist temp var to top of function
travstone Jun 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/js/hopscotch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1945,6 +1945,10 @@
this.showStep = function(stepNum) {
var step = currTour.steps[stepNum];
if(!utils.getStepTarget(step)) {
var prevStepNum = currStepNum;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick... hoist the var declaration to the top of the function.

currStepNum = stepNum;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this. IMO, if the step's target doesn't exist, we should leave the tour where it is. This also is probably the source of the build failure.

utils.invokeEventCallbacks('error');
currStepNum = prevStepNum;
return;
}

Expand Down