Skip to content

Improve error message in LightningCLI if subcommand is not the first argument #19715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve error message in LightningCLI if subcommand is not the first argument #19715

wants to merge 1 commit into from

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Mar 29, 2024 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #19714

📚 Documentation preview 📚: https://pytorch-lightning--19715.org.readthedocs.build/en/19715/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Mar 29, 2024
@awaelchli awaelchli added bug Something isn't working lightningcli pl.cli.LightningCLI and removed pl Generic label for PyTorch Lightning package labels Mar 29, 2024
@awaelchli awaelchli added this to the 2.2.x milestone Mar 29, 2024
@awaelchli awaelchli mentioned this pull request Mar 31, 2024
Open
@awaelchli awaelchli closed this Apr 12, 2024
@Borda Borda deleted the feature/cli-error-missing-stage branch July 26, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga Awaiting requested review from lantiga lantiga will be requested when the pull request is marked ready for review lantiga is a code owner

@Borda Borda Awaiting requested review from Borda Borda will be requested when the pull request is marked ready for review Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton will be requested when the pull request is marked ready for review tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock will be requested when the pull request is marked ready for review justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris will be requested when the pull request is marked ready for review ethanwharris is a code owner

Assignees
No one assigned
Labels
bug Something isn't working lightningcli pl.cli.LightningCLI
Projects
None yet
Milestone
2.2.x
Development

Successfully merging this pull request may close these issues.

Mixing the order of --config and fit in LightningCLI can cause confusion
1 participant
@awaelchli