Skip to content

Update the Multi-GPU docs #19525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 27, 2024
Merged

Update the Multi-GPU docs #19525

merged 7 commits into from
Feb 27, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 24, 2024 •
edited by github-actions bot
Loading

What does this PR do?

The "intermediate"-level multi-GPU docs page contains a lot of outdated, incorrect or redundant information. Overall, the page is not great and should probably be rewritten. This PR does some "damage control" and fixes a few things, but it could use a few iterations in other places as well in follow ups.

Closes #18614

📚 Documentation preview 📚: https://pytorch-lightning--19525.org.readthedocs.build/en/19525/

cc @Borda @justusschock @awaelchli

@github-actions github-actions bot added docs Documentation related pl Generic label for PyTorch Lightning package labels Feb 24, 2024
@awaelchli awaelchli added this to the 2.3 milestone Feb 24, 2024
awaelchli
awaelchli commented Feb 25, 2024
View reviewed changes
awaelchli
awaelchli commented Feb 25, 2024
View reviewed changes
awaelchli
awaelchli commented Feb 25, 2024
View reviewed changes
@awaelchli awaelchli marked this pull request as ready for review February 25, 2024 16:18
@awaelchli awaelchli added strategy: ddp DistributedDataParallel environment: torchelastic fun Staff contributions outside working hours - to differentiate from the "community" label labels Feb 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2024 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to docs/source-pytorch/accelerators/gpu_intermediate.rst, docs/source-pytorch/clouds/cluster_advanced.rst, docs/source-pytorch/clouds/cluster_intermediate_1.rst, docs/source-pytorch/clouds/cluster_intermediate_2.rst, docs/source-pytorch/glossary/index.rst.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@awaelchli awaelchli requested a review from carmocca February 25, 2024 16:25
@awaelchli awaelchli requested a review from tchaton as a code owner February 25, 2024 20:44
carmocca
carmocca approved these changes Feb 26, 2024
View reviewed changes
@mergify mergify bot added the ready PRs ready to be merged label Feb 26, 2024
@awaelchli awaelchli merged commit e461e90 into master Feb 27, 2024
@awaelchli awaelchli deleted the docs/multi-gpu branch February 27, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees
No one assigned
Labels
docs Documentation related environment: torchelastic fun Staff contributions outside working hours - to differentiate from the "community" label pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: ddp DistributedDataParallel
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@awaelchli @Borda @carmocca