Skip to content

Bump bitsandbytes minimum version #19520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 4, 2024
Merged

Bump bitsandbytes minimum version #19520

merged 12 commits into from
Mar 4, 2024

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Feb 23, 2024 •
edited by github-actions bot
Loading

What does this PR do?

Check to see if the new property can be used else revert to the older API

needed for Lightning-AI/litgpt#946

📚 Documentation preview 📚: https://pytorch-lightning--19520.org.readthedocs.build/en/19520/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Feb 23, 2024
@kashif kashif mentioned this pull request Feb 23, 2024
Merged
@github-actions github-actions bot added pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Feb 23, 2024
@awaelchli awaelchli added community This PR is from the community precision: bnb Bitsandbytes quantization labels Feb 23, 2024
@awaelchli awaelchli added this to the 2.3 milestone Feb 23, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 23, 2024 •
edited
Loading

Codecov Report

Merging #19520 (540527c) into master (b19c3a9) will decrease coverage by 26%.
The diff coverage is 100%.

Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #19520     +/-   ##
=========================================
- Coverage      84%      58%    -26%     
=========================================
  Files         424      419      -5     
  Lines       34921    34823     -98     
=========================================
- Hits        29355    20371   -8984     
- Misses       5566    14452   +8886

Borda
Borda previously requested changes Feb 23, 2024
View reviewed changes
@kashif
Copy link
Contributor Author

kashif commented Feb 23, 2024

@Borda are you stalking me 🤪

Titus-von-Koeller
Titus-von-Koeller approved these changes Feb 26, 2024
View reviewed changes
Copy link

@Titus-von-Koeller Titus-von-Koeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone, really appreciated! Everything looks good to me.

@awaelchli awaelchli mentioned this pull request Mar 1, 2024
Closed
@awaelchli awaelchli linked an issue Mar 1, 2024 that may be closed by this pull request
Permission denied: '/usr/share/lmod/lmod/init/ksh_funcs/libcudart.so' #19553
Closed
awaelchli
awaelchli approved these changes Mar 2, 2024
View reviewed changes
@awaelchli awaelchli changed the title update bnb quant_state API and unpin version Bump bitsandbytes minimum version Mar 2, 2024
Borda
Borda previously requested changes Mar 4, 2024
View reviewed changes
@awaelchli awaelchli requested a review from Borda March 4, 2024 12:56
@mergify mergify bot added the ready PRs ready to be merged label Mar 4, 2024
carmocca
carmocca approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoping that this is everything that needs an update. Tests seem to agree with htis.

@carmocca carmocca merged commit 527d071 into Lightning-AI:master Mar 4, 2024
@kashif kashif deleted the bnb-update branch March 4, 2024 15:12
@carmocca carmocca mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@Titus-von-Koeller Titus-von-Koeller Titus-von-Koeller approved these changes

@carmocca carmocca carmocca approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees

@carmocca carmocca

Labels
community This PR is from the community dependencies Pull requests that update a dependency file fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package precision: bnb Bitsandbytes quantization ready PRs ready to be merged
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

Permission denied: '/usr/share/lmod/lmod/init/ksh_funcs/libcudart.so'
5 participants
@kashif @awaelchli @Borda @Titus-von-Koeller @carmocca