-
Notifications
You must be signed in to change notification settings - Fork 199
Fix: Add Callback Events and Align Hooks in Streaming Loop #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aniketmaurya
merged 9 commits into
Lightning-AI:main
from
bhimrazy:fix/add-missing-callback
Jan 13, 2025
Merged
Fix: Add Callback Events and Align Hooks in Streaming Loop #407
aniketmaurya
merged 9 commits into
Lightning-AI:main
from
bhimrazy:fix/add-missing-callback
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
aniketmaurya
reviewed
Jan 9, 2025
…SE events to execute after generator stops
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
===================================
Coverage 89% 90%
===================================
Files 31 31
Lines 2017 2020 +3
===================================
+ Hits 1804 1811 +7
+ Misses 213 209 -4 |
aniketmaurya
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @bhimrazy! let's goo 🚀
aniketmaurya
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
after_predict
>after_encode_response
) and ensures they run only after the generator completes.after
hooks are executed only once the generator finishes processing all tasks.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃