🗺️ fix: Generate Missing Babel Map File #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifies node 16, so 10 is likely outdated in the CONTRIBUTING.md file. The README.md file does not contain the steps from the CONTRIBUTING.md file for building the codesandbox-browserfs package. I suspect the yarn build:deps script needs to be updated to do this correctly, but the yarn start script does end up building this correctly. If you follow the instructions as written you get errors in both yarn build:deps and yarn build:sandpack, but if you use yarn start, you do not.
… and additional build step
danny-avila
force-pushed
the
networkninja-fix-babel-sourcemap
branch
from
97cc488 to
5de8c20
Compare
danny-avila
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally #3
What kind of change does this PR introduce? Bug fix
What is the current behavior? #1
What is the new behavior? No more missing map file.
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
babel.min.js.mapfile (based onnode_modules/@babel/standalone/babel.jsunminified javascript.Checklist
One thing worth mentioning is that this does not solve the issue raised in #2 - I don't believe that issue is a duplicate of the issue I'm addressing.
Nor does it solve this issue raised in LIbrechat that was converted to a discussion: danny-avila/LibreChat#3989
I can assure you that this is not related to a network problem, as running the server on both AWS infrastructure and on localhost has resulted in the same timeout errors being issued, and it seems to only apply to certain artifacts.
Also you may not agree with my README changes, the
codesandbox-browserfsmodule does not get built unless you use the instructions in the CONTRIBUTING.md file (Specifically by runningyarn startto force thecodesandbox-browserfsbuild)