Skip to content

Improve Success Message #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve Success Message #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/redis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,10 @@ module.exports = CoreObject.extend({
_deploySuccessMessage: function(revisionKey) {
var success = green('\nUpload successful!\n\n');
var uploadMessage = white('Uploaded revision: ')+green(revisionKey);
var exampleCommand = white('To activate, execute: \n\n')+
green('ember deploy:activate -r ' + revisionKey + '-e ' + this.config.environment);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LevelbossMike this most likely won't work, since this.config.environment is a guessed variable, and most likely undefined.

What would be the best way to access the environment?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately you don't have access to the environment via the config object. this will be possible in the upcoming versions of ember-deploy with the deployment-pipeline and the new hooks-architecture.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could patch this in the configuration-reader of ember-cli-deploy and pass the environment there but this is kind of messy and will be fixed via the upcoming changes in ember-cli-deploy itself.

This would be a great addition to ember-deploy-redis. Thanks for catching this. I'll leave this open and ping you when ember-cli-deploy is ready.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks I'll keep my eyes peeled


return success + uploadMessage;
return success + uploadMessage + exampleCommand;
},

_deployErrorMessage: function() {
Expand Down