Skip to content

fix (coin-stellar): operation identifiers are wrong #9708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

fix (coin-stellar): operation identifiers are wrong #9708

merged 1 commit into from
Mar 28, 2025
+6 −1

Conversation

francois-guerin-ledger
Copy link
Contributor

@francois-guerin-ledger francois-guerin-ledger commented Mar 28, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

This partially reverts #9584.

The way operation identifiers are built has changed (using Stellar transaction id), whereas new operations continue to use the old way (using Stellar transaction hash).

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@francois-guerin-ledger francois-guerin-ledger requested a review from a team as a code owner March 28, 2025 08:29
@vercel Vercel
Copy link

vercel bot commented Mar 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 8:31am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Mar 28, 2025 8:31am
native-ui-storybook ⬜️ Ignored (Inspect) Mar 28, 2025 8:31am
react-ui-storybook ⬜️ Ignored (Inspect) Mar 28, 2025 8:31am

@github-actions GitHub Actions
Copy link
Contributor

[Bot] Testing with 'Nitrogen' ✅ 2 txs ($18.30) ⏲ 2min 51s

✅ 1 specs are successful: Stellar

What is the bot and how does it work? Everything is documented here!

⚠️ 1 spec hints
  • Spec Stellar:
    • mutations should define a testDestination(): Send max XLM, move ~50% XLM
Details of the 2 mutations

Spec Stellar (6)

Spec Stellar found 6 Stellar accounts. Will use Stellar 5.5.0 on nanoSP 1.1.2
undefined: 1.56141 XLM (238ops) (GDJPZPOWITPCBX3TIHB6N7E4WCHS6JBZKSNWGU34QYCJXKWBTUZY5RYC on 44'/148'/0') sep5#0 js:2:stellar:GDJPZPOWITPCBX3TIHB6N7E4WCHS6JBZKSNWGU34QYCJXKWBTUZY5RYC:sep5
undefined: 1.66331 XLM (385ops) (GC25SBJ3F2XGWRTS3DGPCNFAGQLNDBFUKUJREJMHVV2JIUBZSVY2GAHZ on 44'/148'/1') sep5#1 js:2:stellar:GC25SBJ3F2XGWRTS3DGPCNFAGQLNDBFUKUJREJMHVV2JIUBZSVY2GAHZ:sep5
undefined: 40.7168 XLM (195ops) (GA4A2FH4YYI2RXPUC3NPGZQP7XX4CEJNREB27XVX7B7D5RIA3KOLSKTI on 44'/148'/2') sep5#2 js:2:stellar:GA4A2FH4YYI2RXPUC3NPGZQP7XX4CEJNREB27XVX7B7D5RIA3KOLSKTI:sep5
undefined: 2.36747 XLM (223ops) (GDTKZ5E53DELQO33QAYYR6TS4JX44MP2PGCRGKY3RE42IT7PUNLU2SHM on 44'/148'/3') sep5#3 js:2:stellar:GDTKZ5E53DELQO33QAYYR6TS4JX44MP2PGCRGKY3RE42IT7PUNLU2SHM:sep5
undefined: 20.1688 XLM (238ops) (GBV2ROL25KKDSFCZC2TQPMUEN567YQHRWTRBYHCO5AKYWVIV4JKJ56AF on 44'/148'/4') sep5#4 js:2:stellar:GBV2ROL25KKDSFCZC2TQPMUEN567YQHRWTRBYHCO5AKYWVIV4JKJ56AF:sep5
undefined: 0 XLM (0ops) (GCMN2KYJPPHB4TMXXF2OZPMWVM5EQSDD76IMFOMET7YMN64VJDVHVNCM on 44'/148'/5') sep5#5 js:2:stellar:GCMN2KYJPPHB4TMXXF2OZPMWVM5EQSDD76IMFOMET7YMN64VJDVHVNCM:sep5
necessary accounts resynced in 0.16ms
▬ Stellar 5.5.0 on nanoSP 1.1.2
→ FROM undefined: 1.66331 XLM (385ops) (GC25SBJ3F2XGWRTS3DGPCNFAGQLNDBFUKUJREJMHVV2JIUBZSVY2GAHZ on 44'/148'/1') sep5#1 js:2:stellar:GC25SBJ3F2XGWRTS3DGPCNFAGQLNDBFUKUJREJMHVV2JIUBZSVY2GAHZ:sep5 (! sum of ops -10.5568991 XLM)  TokenAccount USDC: 0 usdc (0 ops)
max spendable ~0.163293
★ using mutation 'Send max XLM'
→ TO undefined: 40.7168 XLM (195ops) (GA4A2FH4YYI2RXPUC3NPGZQP7XX4CEJNREB27XVX7B7D5RIA3KOLSKTI on 44'/148'/2') sep5#2 js:2:stellar:GA4A2FH4YYI2RXPUC3NPGZQP7XX4CEJNREB27XVX7B7D5RIA3KOLSKTI:sep5
✔️ transaction 
    SEND MAX
    TO GA4A2FH4YYI2RXPUC3NPGZQP7XX4CEJNREB27XVX7B7D5RIA3KOLSKTI
    with fees=0.0005 XLM
  memo=Ledger Live
STATUS (3.5s)
  amount: 0.1628038 XLM
  estimated fees: 0.0005 XLM
  total spent: 0.1628038 XLM
errors: 
warnings: 
✔️ has been signed! (3.9s) 
✔️ broadcasted! (9.5s) optimistic operation: 
  -0.1628038 XLM     OUT        56116e82237b29b14d1f57144ee97d7bf37157d6cfabc1e3941ad9e9fe119a81 2025-03-28T09:46
✔️ operation confirmed (12.1s): 
  -0.1628038 XLM     OUT        56116e82237b29b14d1f57144ee97d7bf37157d6cfabc1e3941ad9e9fe119a81 2025-03-28T09:46
✔️ undefined: 1.5005 XLM (386ops) (GC25SBJ3F2XGWRTS3DGPCNFAGQLNDBFUKUJREJMHVV2JIUBZSVY2GAHZ on 44'/148'/1') sep5#1 js:2:stellar:GC25SBJ3F2XGWRTS3DGPCNFAGQLNDBFUKUJREJMHVV2JIUBZSVY2GAHZ:sep5 (! sum of ops -10.7197029 XLM)  TokenAccount USDC: 0 usdc (0 ops)(in 12.1s)

necessary accounts resynced in 2250ms
▬ Stellar 5.5.0 on nanoSP 1.1.2
→ FROM undefined: 40.8796 XLM (196ops) (GA4A2FH4YYI2RXPUC3NPGZQP7XX4CEJNREB27XVX7B7D5RIA3KOLSKTI on 44'/148'/2') sep5#2 js:2:stellar:GA4A2FH4YYI2RXPUC3NPGZQP7XX4CEJNREB27XVX7B7D5RIA3KOLSKTI:sep5 (! sum of ops -18.6130051 XLM)  TokenAccount USDC: 0 usdc (0 ops)
max spendable ~39.3796
★ using mutation 'move ~50% XLM'
→ TO undefined: 1.56141 XLM (238ops) (GDJPZPOWITPCBX3TIHB6N7E4WCHS6JBZKSNWGU34QYCJXKWBTUZY5RYC on 44'/148'/0') sep5#0 js:2:stellar:GDJPZPOWITPCBX3TIHB6N7E4WCHS6JBZKSNWGU34QYCJXKWBTUZY5RYC:sep5
✔️ transaction 
    SEND 20.6362365 XLM
    TO GDJPZPOWITPCBX3TIHB6N7E4WCHS6JBZKSNWGU34QYCJXKWBTUZY5RYC
    with fees=0.0005 XLM
  memo=Ledger Live
STATUS (3.6s)
  amount: 20.6362365 XLM
  estimated fees: 0.0005 XLM
  total spent: 20.6367365 XLM
errors: 
warnings: 
✔️ has been signed! (4s) 
✔️ broadcasted! (5.5s) optimistic operation: 
  -20.6362365 XLM    OUT        fd12067429f1b9945647c0b651bc4a504b18cd11f70900640400a94db1a93389 2025-03-28T09:46
✔️ operation confirmed (11.9s): 
  -20.6362365 XLM    OUT        fd12067429f1b9945647c0b651bc4a504b18cd11f70900640400a94db1a93389 2025-03-28T09:46
✔️ undefined: 20.2433 XLM (197ops) (GA4A2FH4YYI2RXPUC3NPGZQP7XX4CEJNREB27XVX7B7D5RIA3KOLSKTI on 44'/148'/2') sep5#2 js:2:stellar:GA4A2FH4YYI2RXPUC3NPGZQP7XX4CEJNREB27XVX7B7D5RIA3KOLSKTI:sep5 (! sum of ops -39.2492416 XLM)  TokenAccount USDC: 0 usdc (0 ops)(in 11.9s)
Details of the 2 uncovered mutations

Spec Stellar (2)

  • add USDC asset: XLM balance is too low 1 (3), already have subaccounts (1)
  • move ~50% USDC asset: XLM balance is too low (2), USDC balance is too low (2)
Portfolio ($18.30) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
Stellar (6) 1283 ops (+4), 58.9778 XLM ($18.30) 💪 999+ GDJPZPOWITPCBX3TIHB6N7E4WCHS6JBZKSNWGU34QYCJXKWBTUZY5RYC 
undefined: 22.1976 XLM (239ops) (GDJPZPOWITPCBX3TIHB6N7E4WCHS6JBZKSNWGU34QYCJXKWBTUZY5RYC on 44'/148'/0') sep5#0 js:2:stellar:GDJPZPOWITPCBX3TIHB6N7E4WCHS6JBZKSNWGU34QYCJXKWBTUZY5RYC:sep5
undefined: 1.5005 XLM (386ops) (GC25SBJ3F2XGWRTS3DGPCNFAGQLNDBFUKUJREJMHVV2JIUBZSVY2GAHZ on 44'/148'/1') sep5#1 js:2:stellar:GC25SBJ3F2XGWRTS3DGPCNFAGQLNDBFUKUJREJMHVV2JIUBZSVY2GAHZ:sep5
undefined: 20.2433 XLM (197ops) (GA4A2FH4YYI2RXPUC3NPGZQP7XX4CEJNREB27XVX7B7D5RIA3KOLSKTI on 44'/148'/2') sep5#2 js:2:stellar:GA4A2FH4YYI2RXPUC3NPGZQP7XX4CEJNREB27XVX7B7D5RIA3KOLSKTI:sep5
undefined: 2.36747 XLM (223ops) (GDTKZ5E53DELQO33QAYYR6TS4JX44MP2PGCRGKY3RE42IT7PUNLU2SHM on 44'/148'/3') sep5#3 js:2:stellar:GDTKZ5E53DELQO33QAYYR6TS4JX44MP2PGCRGKY3RE42IT7PUNLU2SHM:sep5
undefined: 20.1688 XLM (238ops) (GBV2ROL25KKDSFCZC2TQPMUEN567YQHRWTRBYHCO5AKYWVIV4JKJ56AF on 44'/148'/4') sep5#4 js:2:stellar:GBV2ROL25KKDSFCZC2TQPMUEN567YQHRWTRBYHCO5AKYWVIV4JKJ56AF:sep5
undefined: 0 XLM (0ops) (GCMN2KYJPPHB4TMXXF2OZPMWVM5EQSDD76IMFOMET7YMN64VJDVHVNCM on 44'/148'/5') sep5#5 js:2:stellar:GCMN2KYJPPHB4TMXXF2OZPMWVM5EQSDD76IMFOMET7YMN64VJDVHVNCM:sep5
Performance ⏲ 2min 51s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 0.84ms 1min 42s 4.2s 7.2s 7.9s 15s 24s N/A
Stellar (5) 0.84ms 1min 42s 4.2s 7.2s 7.9s 15s 24s N/A

What is the bot and how does it work? Everything is documented here!

@francois-guerin-ledger francois-guerin-ledger merged commit 9690477 into release Mar 28, 2025
55 of 60 checks passed
@francois-guerin-ledger francois-guerin-ledger deleted the fix/LIVE-17945-wrong-indexation branch March 28, 2025 09:59
@francois-guerin-ledger francois-guerin-ledger mentioned this pull request Apr 2, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justkant Justkant Justkant approved these changes

Assignees

@francois-guerin-ledger francois-guerin-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francois-guerin-ledger @Justkant