Skip to content

fix: specs celo and Icon #9386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

fix: specs celo and Icon #9386

merged 1 commit into from
Feb 28, 2025

Conversation

qperrot
Copy link
Contributor

@qperrot qperrot commented Feb 28, 2025 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Feb 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 10:12am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Feb 28, 2025 10:12am
native-ui-storybook ⬜️ Ignored (Inspect) Feb 28, 2025 10:12am
react-ui-storybook ⬜️ Ignored (Inspect) Feb 28, 2025 10:12am

@live-github-bot live-github-bot bot added the common Has changes in live-common label Feb 28, 2025
@qperrot qperrot marked this pull request as ready for review February 28, 2025 10:12
@qperrot qperrot requested a review from a team as a code owner February 28, 2025 10:12
@github-actions GitHub Actions
Copy link
Contributor

[Bot] Testing with 'Nitrogen' ✅ 1 txs ($6.06) ⏲ 66.4s

✅ 1 specs are successful: Celo

What is the bot and how does it work? Everything is documented here!

⚠️ 2 spec hints
  • Spec Celo:
    • mutations should define a test(): Celo: Move 50% to another account
    • mutations should define a testDestination(): Celo: Move 50% to another account
Details of the 1 mutations

Spec Celo (12)

Spec Celo found 12 Celo accounts (preload: 982ms). Will use Celo 1.3.2 on nanoS 2.1.0
undefined: 0.00286957 CELO (285ops) (0x246FFDB387F1F8c48072E1C13443540017bC71b7 on 44'/52752'/0'/0/0) #0 js:2:celo:0x246FFDB387F1F8c48072E1C13443540017bC71b7:
undefined: 0.0408483 CELO (222ops) (0xfbD6f2Ee91DdEFFB77FA360d851d5f305BE9ceF8 on 44'/52752'/1'/0/0) #1 js:2:celo:0xfbD6f2Ee91DdEFFB77FA360d851d5f305BE9ceF8:
undefined: 0.0207049 CELO (222ops) (0x7993d97bbB2328a9Daf24f3d9855d7cc85f0c2A0 on 44'/52752'/2'/0/0) #2 js:2:celo:0x7993d97bbB2328a9Daf24f3d9855d7cc85f0c2A0:
undefined: 0.815722 CELO (196ops) (0x709b0F0Ba5719F76320d96195D17a56d35dcf1f2 on 44'/52752'/3'/0/0) #3 js:2:celo:0x709b0F0Ba5719F76320d96195D17a56d35dcf1f2:
undefined: 0.0312566 CELO (184ops) (0xA6EB5541E3527d07CaD4dD14E5454820DB858160 on 44'/52752'/4'/0/0) #4 js:2:celo:0xA6EB5541E3527d07CaD4dD14E5454820DB858160:
undefined: 0.150226 CELO (170ops) (0x6baA538b3eC946E822E1cE1D1E55849A3cfc52EE on 44'/52752'/5'/0/0) #5 js:2:celo:0x6baA538b3eC946E822E1cE1D1E55849A3cfc52EE:
undefined: 8.05467 CELO (165ops) (0x0119a3BCC7140f0cab7bBcA6340838B05Ab80bBc on 44'/52752'/6'/0/0) #6 js:2:celo:0x0119a3BCC7140f0cab7bBcA6340838B05Ab80bBc:
undefined: 1.81167 CELO (179ops) (0xc054A142A0e8793bC860A34971C3eb549064A54a on 44'/52752'/7'/0/0) #7 js:2:celo:0xc054A142A0e8793bC860A34971C3eb549064A54a:
undefined: 0.0174064 CELO (184ops) (0x78AB368133f5Bf101849475dD4a5747E6d1A897a on 44'/52752'/8'/0/0) #8 js:2:celo:0x78AB368133f5Bf101849475dD4a5747E6d1A897a:
undefined: 1.90568 CELO (160ops) (0xC9832b63fd0ADb1a2F59C9616E282398aDEcC0a8 on 44'/52752'/9'/0/0) #9 js:2:celo:0xC9832b63fd0ADb1a2F59C9616E282398aDEcC0a8:
undefined: 3.52296 CELO (147ops) (0x3f6AB52EDA4a9d38b3cf208E3fB4c3f87C53002D on 44'/52752'/10'/0/0) #10 js:2:celo:0x3f6AB52EDA4a9d38b3cf208E3fB4c3f87C53002D:
undefined: 0 CELO (0ops) (0xA07f9fb2bd5A8799081d5519897dB27B257D036D on 44'/52752'/11'/0/0) #11 js:2:celo:0xA07f9fb2bd5A8799081d5519897dB27B257D036D:
necessary accounts resynced in 0.11ms
▬ Celo 1.3.2 on nanoS 2.1.0
→ FROM undefined: 0.815722 CELO (196ops) (0x709b0F0Ba5719F76320d96195D17a56d35dcf1f2 on 44'/52752'/3'/0/0) #3 js:2:celo:0x709b0F0Ba5719F76320d96195D17a56d35dcf1f2: (! sum of ops 0.86526923914895728 CELO)
max spendable ~0.808656
★ using mutation 'Celo: Move 50% to another account'
→ TO undefined: 1.90568 CELO (160ops) (0xC9832b63fd0ADb1a2F59C9616E282398aDEcC0a8 on 44'/52752'/9'/0/0) #9 js:2:celo:0xC9832b63fd0ADb1a2F59C9616E282398aDEcC0a8:
✔️ transaction 
SEND 0.404328390980609628 CELO
TO 0xC9832b63fd0ADb1a2F59C9616E282398aDEcC0a8
STATUS (1315ms)
  amount: 0.404328390980609628 CELO
  estimated fees: 0.00335115 CELO
  total spent: 0.407679540980609628 CELO
errors: 
warnings: 
✔️ has been signed! (3.2s) 
✔️ broadcasted! (2340ms) optimistic operation: 
  -0.407679540980609628 CELO OUT        0xae4434bc88a6e75b852c9b2ec57b25c861f173704e15241b692b682ad7c51a97 2025-02-28T10:17
✔️ operation confirmed (12.8s): 
  -0.4043283909806096 CELO OUT        0xae4434bc88a6e75b852c9b2ec57b25c861f173704e15241b692b682ad7c51a97 2025-02-28T10:17
✔️ undefined: 0.410827 CELO (197ops) (0x709b0F0Ba5719F76320d96195D17a56d35dcf1f2 on 44'/52752'/3'/0/0) #3 js:2:celo:0x709b0F0Ba5719F76320d96195D17a56d35dcf1f2: (! sum of ops 0.46094084816834768 CELO)(in 12.8s)
Portfolio ($6.06) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
Celo (12) 2116 ops (+2), 16.283 CELO ($6.06) 💪 999+ 0x246FFDB387F1F8c48072E1C13443540017bC71b7 
undefined: 0.00286957 CELO (285ops) (0x246FFDB387F1F8c48072E1C13443540017bC71b7 on 44'/52752'/0'/0/0) #0 js:2:celo:0x246FFDB387F1F8c48072E1C13443540017bC71b7:
undefined: 0.0408483 CELO (222ops) (0xfbD6f2Ee91DdEFFB77FA360d851d5f305BE9ceF8 on 44'/52752'/1'/0/0) #1 js:2:celo:0xfbD6f2Ee91DdEFFB77FA360d851d5f305BE9ceF8:
undefined: 0.0207049 CELO (222ops) (0x7993d97bbB2328a9Daf24f3d9855d7cc85f0c2A0 on 44'/52752'/2'/0/0) #2 js:2:celo:0x7993d97bbB2328a9Daf24f3d9855d7cc85f0c2A0:
undefined: 0.410827 CELO (197ops) (0x709b0F0Ba5719F76320d96195D17a56d35dcf1f2 on 44'/52752'/3'/0/0) #3 js:2:celo:0x709b0F0Ba5719F76320d96195D17a56d35dcf1f2:
undefined: 0.0312566 CELO (184ops) (0xA6EB5541E3527d07CaD4dD14E5454820DB858160 on 44'/52752'/4'/0/0) #4 js:2:celo:0xA6EB5541E3527d07CaD4dD14E5454820DB858160:
undefined: 0.150226 CELO (170ops) (0x6baA538b3eC946E822E1cE1D1E55849A3cfc52EE on 44'/52752'/5'/0/0) #5 js:2:celo:0x6baA538b3eC946E822E1cE1D1E55849A3cfc52EE:
undefined: 8.05467 CELO (165ops) (0x0119a3BCC7140f0cab7bBcA6340838B05Ab80bBc on 44'/52752'/6'/0/0) #6 js:2:celo:0x0119a3BCC7140f0cab7bBcA6340838B05Ab80bBc:
undefined: 1.81167 CELO (179ops) (0xc054A142A0e8793bC860A34971C3eb549064A54a on 44'/52752'/7'/0/0) #7 js:2:celo:0xc054A142A0e8793bC860A34971C3eb549064A54a:
undefined: 0.0174064 CELO (184ops) (0x78AB368133f5Bf101849475dD4a5747E6d1A897a on 44'/52752'/8'/0/0) #8 js:2:celo:0x78AB368133f5Bf101849475dD4a5747E6d1A897a:
undefined: 2.31001 CELO (161ops) (0xC9832b63fd0ADb1a2F59C9616E282398aDEcC0a8 on 44'/52752'/9'/0/0) #9 js:2:celo:0xC9832b63fd0ADb1a2F59C9616E282398aDEcC0a8:
undefined: 3.52296 CELO (147ops) (0x3f6AB52EDA4a9d38b3cf208E3fB4c3f87C53002D on 44'/52752'/10'/0/0) #10 js:2:celo:0x3f6AB52EDA4a9d38b3cf208E3fB4c3f87C53002D:
undefined: 0 CELO (0ops) (0xA07f9fb2bd5A8799081d5519897dB27B257D036D on 44'/52752'/11'/0/0) #11 js:2:celo:0xA07f9fb2bd5A8799081d5519897dB27B257D036D:
Performance ⏲ 66.4s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 982ms 38.7s 2770ms 1315ms 3.2s 2340ms 12.8s N/A
Celo (11) 982ms 38.7s 2770ms 1315ms 3.2s 2340ms 12.8s N/A

What is the bot and how does it work? Everything is documented here!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 7ms

What is the bot and how does it work? Everything is documented here!

Details of the 0 mutations
Portfolio ($0.00) – Details of the 0 currencies
Spec (accounts) State Remaining Runs (est) funds?
Performance ⏲ 7ms

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL N/A N/A N/A N/A N/A N/A N/A N/A

What is the bot and how does it work? Everything is documented here!

@qperrot qperrot added this pull request to the merge queue Feb 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 7ms

What is the bot and how does it work? Everything is documented here!

Details of the 0 mutations
Portfolio ($0.00) – Details of the 0 currencies
Spec (accounts) State Remaining Runs (est) funds?
Performance ⏲ 7ms

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL N/A N/A N/A N/A N/A N/A N/A N/A

What is the bot and how does it work? Everything is documented here!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2025
@qperrot qperrot added this pull request to the merge queue Feb 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2025
@qperrot qperrot added this pull request to the merge queue Feb 28, 2025
Merged via the queue into develop with commit ad4b70f Feb 28, 2025
66 of 72 checks passed
@qperrot qperrot deleted the bugfix/spec-celo-icon branch February 28, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedi-edelbloute hedi-edelbloute hedi-edelbloute approved these changes

@ComradeAERGO ComradeAERGO ComradeAERGO approved these changes

Assignees

@qperrot qperrot

Labels
common Has changes in live-common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qperrot @hedi-edelbloute @ComradeAERGO