Skip to content

investigate: add video capture for ios e2e and add a fixed delay for swap drawer check #10461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

buyochini
Copy link
Contributor

@buyochini buyochini commented Jun 7, 2025

…en waiting for swap success screen

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@buyochini buyochini requested review from a team as code owners June 7, 2025 15:10
Copy link

vercel bot commented Jun 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2025 8:43am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2025 8:43am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2025 8:43am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2025 8:43am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jun 7, 2025
@buyochini
Copy link
Contributor Author

@ypolishchuk-ledger
Copy link
Contributor

@buyochini from your execution report I see one of the tests failed without waiting for element to be visible, hence video is 0 seconds long: https://ledger-live.allure.green.ledgerlabs.net/allure/reports/01cf633c-1934-4fea-8b8d-fa167cdb3915/#suites/041e040e1eae13f95ef6964f8fa5e242/9c7ce8dcea8e613b/

@buyochini buyochini changed the title investigate: add video capture for ios and increase timeout period wh… investigate: add video capture for ios e2e and add a fixed delay for swap drawer check Jun 9, 2025
@buyochini
Copy link
Contributor Author

buyochini commented Jun 9, 2025

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
23.7% Coverage on New Code (required ≥ 80%)
60 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@buyochini
Copy link
Contributor Author

@buyochini buyochini merged commit bd7c325 into develop Jun 10, 2025
66 of 74 checks passed
@buyochini buyochini deleted the support/qaa-647 branch June 10, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants