feat: add custom webview loader for Buy/Sell #10305
Open
+508
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
live-github-bot
bot
added
desktop
mwiercinska
force-pushed
the
LIVE-17147-buy-sell-custom-loader
branch
from
05d1b36 to
2d6fd3f
Compare
mwiercinska
force-pushed
the
LIVE-17147-buy-sell-custom-loader
branch
3 times, most recently
from
86c0952 to
29239a4
Compare
hhumphrey-ledger
force-pushed
the
LIVE-17147-buy-sell-custom-loader
branch
from
4274195 to
2e0769f
Compare
sarneijim
previously approved these changes
Jun 5, 2025
hhumphrey-ledger
force-pushed
the
LIVE-17147-buy-sell-custom-loader
branch
from
308cc26 to
93425b8
Compare
hhumphrey-ledger
force-pushed
the
LIVE-17147-buy-sell-custom-loader
branch
2 times, most recently
from
b706a9e to
19fdfc2
Compare
hhumphrey-ledger
force-pushed
the
LIVE-17147-buy-sell-custom-loader
branch
from
19fdfc2 to
705f719
Compare
Justkant
reviewed
Jun 10, 2025
Comment on lines
50
to
56
| CustomLoader, | ||
| }: WebviewProps & { | ||
| CustomLoader?: React.ComponentType<{ | ||
| manifest: LiveAppManifest; | ||
| isLoading: boolean; | ||
| }>; | ||
| }) { |
There was a problem hiding this comment.
I think we should be able to directly use the Loader props from WebviewProps instead of adding a new CustomLoader with the same type
Suggested change
| CustomLoader, | |
| }: WebviewProps & { | |
| CustomLoader?: React.ComponentType<{ | |
| manifest: LiveAppManifest; | |
| isLoading: boolean; | |
| }>; | |
| }) { | |
| Loader, | |
| }: WebviewProps) { |
There was a problem hiding this comment.
Good shout! Update added here cc5d404
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Adding a custom loader to enable custom transition between Buy/Sell and providers in LLM and LLD.
Demo
❓ Context
🧐 Checklist for the PR Reviewers