Skip to content
This repository was archived by the owner on Nov 23, 2020. It is now read-only.

Add Support for latest laravel versions (7.x, 8.x) #435

Closed
wants to merge 1 commit into from

Conversation

lamungu
Copy link

@lamungu lamungu commented Oct 13, 2020

This PR's purpose is to add compatibility for backpack/base onto latest releases of Laravel 7.x and 8.x

Change involves composer.json's package list, akin to the last PR involving a Laravel upgrade (#403)

@welcome
Copy link

welcome bot commented Oct 13, 2020

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

  • if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
  • even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
  • not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
  • we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

--
Justin Case
The Backpack Robot

@request-info
Copy link

request-info bot commented Oct 13, 2020

Hi there!

Could you please provide us with more info about this? Looks like you skipped the title/body.

Thank you!

--
Justin Case
The Backpack Robot

@tabacitu
Copy link
Member

Hi @lamungu ,

Thanks for the PR, but I'm pretty sure it's not that easy. In those versions Laravel has moved its Authentication to a different packages + a number of other breaking changes that would affect this package. And it will continue to do so, I'm certain.

TLDR:

  • Backpack 4.x already offers support for Laravel 7.x and 8.x; and it does not use Backpack\Base at all; for using Backpack with Laravel 7.x, 8.x and above - please use Backpack 4.x;
  • Backpack 3.x (which requires Backpack\Base) will not be receiving support for future versions of Laravel past 6.x, it's been superseded by Backpack 4.x (released more than one year ago - Sep 2019); and it's deprecated; it's not archived on Github just so that people who are unable to upgrade can still use it; but people really should be upgrading their apps;

Check out https://github.com/Laravel-Backpack/CRUD

Cheers!

@tabacitu
Copy link
Member

PS. I've just updated the README so that the above is clearer. Sorry for that - looks like it wasn't clear at all. I've also marked the package as Abandoned on Packagist - hopefully this will nudge people into upgrading to 4.x

If this causes any problems to anyone, please let me know!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants